New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 609890 link

Starred by 3 users
Status: Fixed
Owner:
dalecur...@chromium.org
Closed: May 2018
Cc:
tommi@chromium.org
m...@chromium.org
█ olka@chromium.org
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove dead bits_per_sample property from media::AudioParameters

Project Member Reported by m...@chromium.org, May 6 2016 
The bits_per_sample property in media::AudioParameters is a legacy wart: Audio data throughout the Chrome Audio stack has standardized on 32-bit float planar format, and that format is used regardless of this property's value. One might think this is needed for opening platform audio input/output at a specific quantization precision; however, looking throughout the code base, this property has been hard-coded to 16 in all but just a few cases (and, in those cases*, it does not need to be inside the AudioParameters class). Thus, we should remove this wart from the code base.


[*] Example where it is used, but does not need to be in AudioParameters: https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/sounds/audio_stream_handler.cc&rcl=1462533478&l=63

Comment 1 by dalecur...@chromium.org, Feb 10 2017

Cc: -dalecur...@chromium.org -rchtara@chromium.org tommi@chromium.org olka@chromium.org
Owner: dalecur...@chromium.org
Status: Started (was: Available)
I think we can finally do this, which will unblock cleanups around issue 619623. To do this we have to do the following:
- Convert AudioInputCallback::OnData(... uint32_t hardware_delay_bytes ...) to a base::TimeDelta like we did for output.
- Convert users of AudioParameters::GetBytes* methods to do their own math or delete if unnecessary.
- Fix streams which used params.bits_per_sample() to either do nothing or use a fixed value of 16-bits.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9cac7de359173930d9d76fc3631a057845573d0

commit a9cac7de359173930d9d76fc3631a057845573d0
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Thu Aug 24 16:11:10 2017

Switch browser side audio capture path to use base time primitives.

We've been lying about bits_per_sample() all over the code base
ever since we started passing floating point AudioBus objects
around. Lets go ahead and kill the vestiges.

Included with your purchase:
- Cleans up an old AudioInputCallback interface which is long since
  been removed.
- Adds base::TimeTicks capture_time which indicates the time at which
  the audio was received; generally this value is provided directly
  from the OS. If unavailable, we revert to using TimeTicks::Now
- Does not wire this up on the renderer side though. Defer to folk on
  the input path for this cleanup, though they look immediately useful.
- Removes |hardware_latency_bytes| from all browser side callsites.

BUG= 609890 
TEST=no functional changes...

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iaed0c3f816da87da9e4964b35ad62d08dd2b9172
Reviewed-on: https://chromium-review.googlesource.com/592403
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497070}
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/content/browser/renderer_host/media/audio_input_sync_writer.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/content/browser/renderer_host/media/audio_input_sync_writer.h
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/content/browser/speech/speech_recognition_browsertest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/content/browser/speech/speech_recognizer_impl.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/content/browser/speech/speech_recognizer_impl.h
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/content/browser/speech/speech_recognizer_impl_unittest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/alsa/alsa_input.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/android/audio_android_unittest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/android/audio_record_input.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/android/audio_record_input.h
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/android/opensles_input.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/android/opensles_input.h
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/audio_input_controller.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/audio_input_controller.h
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/audio_input_controller_unittest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/audio_input_device.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/audio_input_unittest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/audio_io.h
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/audio_low_latency_input_output_unittest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/cras/cras_input.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/cras/cras_input_unittest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/fake_audio_input_stream.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/mac/audio_input_mac.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/mac/audio_low_latency_input_mac.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/mac/audio_low_latency_input_mac.h
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/mac/audio_low_latency_input_mac_unittest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/pulse/pulse_input.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/pulse/pulse_util.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/pulse/pulse_util.h
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/virtual_audio_input_stream.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/virtual_audio_input_stream_unittest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/win/audio_low_latency_input_win.h
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/audio/win/audio_low_latency_input_win_unittest.cc
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/base/android/java/src/org/chromium/media/AudioRecordInput.java
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/base/audio_capturer_source.h
[modify] https://crrev.com/a9cac7de359173930d9d76fc3631a057845573d0/media/base/audio_parameters.h
Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6af47b8e242449b5e2f8b888f34d287807c9dfc4

commit 6af47b8e242449b5e2f8b888f34d287807c9dfc4
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri May 04 04:09:32 2018

Remove dead bits_per_sample() code from AudioParameters.

BUG= 609890 
TBR=alexander.shalamov@intel.com

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie2ba05773f5f0c929471b3203287a83e17bc6efb
Reviewed-on: https://chromium-review.googlesource.com/1036524
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555976}
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chrome/browser/chromeos/assistant/platform_audio_input_host.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chrome/browser/media/webrtc/webrtc_browsertest_audio.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chrome/renderer/media/cast_rtp_stream.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chromecast/media/audio/cast_audio_manager.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chromecast/media/audio/cast_audio_manager_alsa.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chromecast/media/audio/cast_audio_manager_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chromecast/media/audio/cast_audio_mixer.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chromecast/media/audio/cast_audio_mixer_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chromecast/media/audio/cast_audio_output_stream.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chromecast/media/audio/cast_audio_output_stream_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chromecast/media/cma/backend/android/audio_decoder_android.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/chromecast/media/cma/backend/audio_decoder_for_mixer.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/browser/media/capture/audio_mirroring_manager_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/browser/media/media_internals_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/browser/renderer_host/media/media_devices_manager_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/browser/renderer_host/media/media_stream_manager_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/browser/renderer_host/media/render_frame_audio_input_stream_factory_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/browser/speech/speech_recognition_browsertest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/browser/speech/speech_recognizer_impl.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/public/common/media_stream_request.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/public/renderer/media_stream_utils.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/audio_renderer_mixer_manager.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/audio_renderer_mixer_manager.h
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/audio_renderer_mixer_manager_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/renderer_webaudiodevice_impl.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/renderer_webaudiodevice_impl_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/stream/external_media_stream_audio_source.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/stream/local_media_stream_audio_source.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/stream/media_stream_audio_processor.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/stream/media_stream_audio_processor_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/stream/media_stream_audio_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/stream/mock_media_stream_registry.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/stream/processed_local_audio_source.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/stream/track_audio_renderer.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/stream/webaudio_media_stream_source.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/webrtc/peer_connection_remote_audio_source.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/webrtc/webrtc_audio_renderer.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/webrtc/webrtc_audio_renderer_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/webrtc_local_audio_source_provider.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media_capture_from_element/html_audio_element_capturer_source.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media_recorder/audio_track_opus_encoder.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media_recorder/audio_track_recorder_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/media_recorder/media_recorder_handler_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/pepper/pepper_media_stream_audio_track_host.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/pepper/pepper_platform_audio_input.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/pepper/pepper_platform_audio_output.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/renderer/pepper/pepper_platform_audio_output_dev.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/content/test/renderer_audio_output_stream_factory_context_impl_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/extensions/renderer/api/display_source/wifi_display/wifi_display_audio_encoder_lpcm.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/BUILD.gn
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/alsa/alsa_input.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/alsa/alsa_output.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/alsa/alsa_output_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/alsa/alsa_util.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/alsa/alsa_util.h
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/alsa/audio_manager_alsa.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/android/audio_android_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/android/audio_manager_android.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/android/audio_record_input.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/android/opensles_input.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/android/opensles_output.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/android/opensles_output.h
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_debug_file_writer_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_debug_recording_helper_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_input_controller_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_input_device.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_input_device_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_input_sync_writer_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_low_latency_input_output_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_manager.h
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_manager_base.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_manager_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_output_controller_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_output_device_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_output_proxy_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_output_resampler.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_sync_reader_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/audio_system_test_util.h
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/cras/audio_manager_cras.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/cras/audio_manager_cras.h
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/cras/cras_input.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/cras/cras_input_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/cras/cras_unified.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/cras/cras_unified_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/fake_audio_manager.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/fuchsia/audio_manager_fuchsia.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/mac/audio_input_mac.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/mac/audio_low_latency_input_mac.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/mac/audio_low_latency_input_mac_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/mac/audio_manager_mac.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/pulse/audio_manager_pulse.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/pulse/pulse_input.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/pulse/pulse_output.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/pulse/pulse_output.h
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/pulse/pulse_util.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/pulse/pulse_util.h
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/simple_sources.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/simple_sources_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/sounds/audio_stream_handler.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/virtual_audio_input_stream_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/virtual_audio_output_stream_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/win/audio_low_latency_input_win_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/win/audio_low_latency_output_win.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/win/audio_low_latency_output_win_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/win/audio_manager_win.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/win/audio_output_win_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/audio/win/waveout_output_win.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/BUILD.gn
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_buffer_converter.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_buffer_converter_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_bus.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_bus.h
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_bus_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_converter_perftest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_converter_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_parameters.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_parameters.h
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_parameters_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_renderer_mixer_input_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/audio_renderer_mixer_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/channel_mixer_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/fake_audio_renderer_sink.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/fake_audio_worker_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/ipc/media_param_traits.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/mock_audio_renderer_sink.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/sample_format.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/sample_format.h
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/silent_sink_suspender_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/base/test_helpers.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/blink/webaudiosourceprovider_impl_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/cast/test/fake_media_source.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/cast/test/receiver.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/filters/audio_renderer_algorithm_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/muxers/webm_muxer.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/muxers/webm_muxer_fuzzertest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/muxers/webm_muxer_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/renderers/audio_renderer_impl.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/renderers/audio_renderer_impl_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/media/test/pipeline_integration_test_base.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/services/audio/output_controller_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/services/audio/sync_reader_unittest.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/tools/ipc_fuzzer/fuzzer/fuzzer.cc
[modify] https://crrev.com/6af47b8e242449b5e2f8b888f34d287807c9dfc4/tools/metrics/histograms/histograms.xml

Comment 4 by dalecur...@chromium.org, May 4 2018

Status: Fixed (was: Started)
Fixed assuming this doesn't explode somewhere :o

Comment 5 by anatolid@chromium.org, Jun 7 2018 

[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?
►

Sign in to add a comment