New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609882 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MemoryInfra: TRACE_EVENT_API_SCOPED_TASK_EXECUTION_EVENT is not trace event as name suggests

Project Member Reported by ssid@chromium.org, May 6 2016

Issue description

Background context:go/memory-infra: memory profiling in chrome://tracing

TRACE_EVENT_API_SCOPED_TASK_EXECUTION_EVENT is not adding a trace event and it is a heap profiler specific macro. This should be renamed and moved to heap_profiler.h.
 

Comment 1 by ssid@chromium.org, May 6 2016

Cc: fdoray@chromium.org

Comment 2 by ssid@chromium.org, May 6 2016

Owner: ssid@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abb35f9934c2950cc4f8e0f67afb43e632773018

commit abb35f9934c2950cc4f8e0f67afb43e632773018
Author: ssid <ssid@chromium.org>
Date: Fri May 13 20:34:57 2016

[tracing] Move and rename TRACE_EVENT_API_TASK_EXECUTION_EVENT

The heap profiler specific macros are moved to heap_profiler.h. This CL
also gives a better name to the api. Note that the trace_event.h now
includes heap_profiler.h instead of context_tracker.h and contains the
implementation of TRACE_TASK_EXECUTION because it depends on
base::Location and AllocationContextTracker.

BUG= 609882 

Review-Url: https://codereview.chromium.org/1950313005
Cr-Commit-Position: refs/heads/master@{#393616}

[modify] https://crrev.com/abb35f9934c2950cc4f8e0f67afb43e632773018/base/trace_event/common/trace_event_common.h
[modify] https://crrev.com/abb35f9934c2950cc4f8e0f67afb43e632773018/base/trace_event/heap_profiler.h
[modify] https://crrev.com/abb35f9934c2950cc4f8e0f67afb43e632773018/base/trace_event/heap_profiler_allocation_context_tracker_unittest.cc
[modify] https://crrev.com/abb35f9934c2950cc4f8e0f67afb43e632773018/base/trace_event/trace_event.h

Comment 4 by ssid@chromium.org, May 13 2016

Status: Fixed (was: Untriaged)
Components: Internals>Instrumentation>Memory

Sign in to add a comment