The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1df662834b5dec9a400f4cde1e6acdafd39fa1e2

commit 1df662834b5dec9a400f4cde1e6acdafd39fa1e2
Author: sebsg <sebsg@chromium.org>
Date: Fri Jun 03 00:39:15 2016

Sorted the profiles and credit cards to be used in PaymentRequest.

Also added test methods to set the use count and use date of profiles and cards.

BUG= 609864 
TEST=PersonalDataManagerTestJava

Review-Url: https://codereview.chromium.org/1982623002
Cr-Commit-Position: refs/heads/master@{#397562}

[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2/components/autofill/core/browser/personal_data_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d846c8087715c5c03c98cacdcf59575a81e9f52e

commit d846c8087715c5c03c98cacdcf59575a81e9f52e
Author: johnme <johnme@chromium.org>
Date: Fri Jun 03 10:54:13 2016

Revert of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest. (patchset #12 id:620001 of https://codereview.chromium.org/1982623002/ )

Reason for revert:
This broke the downstream clang-clankium-tot-builder, since PersonalDataManager at least is used by downstream autofill code to get profiles and credit cards: https://goto.google.com/kneae

Original issue's description:
> Sorted the profiles and credit cards to be used in PaymentRequest.
>
> Also added test methods to set the use count and use date of profiles and cards.
>
> BUG= 609864 
> TEST=PersonalDataManagerTestJava
>
> Committed: https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2
> Cr-Commit-Position: refs/heads/master@{#397562}

TBR=mathp@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,sebsg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 609864 

Review-Url: https://codereview.chromium.org/2033323003
Cr-Commit-Position: refs/heads/master@{#397679}

[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e/components/autofill/core/browser/personal_data_manager_unittest.cc

Issue 617129 has been merged into this issue.

johnme@: Please don't revert Chromium patches because of Clankium failures. Clankium depends on Chromium, not the other way around. Chromium engineers do not have visibility into Clankium, but Clankium engineers /do/ have visibility into Chromium. The correct way to proceed is to fix the errors in Clankium. I am going to revert your revert.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3

commit 6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3
Author: rouslan <rouslan@chromium.org>
Date: Fri Jun 03 16:20:14 2016

Reland of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest. (patchset #1 id:1 of https://codereview.chromium.org/2033323003/ )

Reason for revert:
Clankium failures should not revert Chromium. The correct course of action is to fix-up the Clankium code, into which Chromium developers have no visibility.

Original issue's description:
> Revert of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest. (patchset #12 id:620001 of https://codereview.chromium.org/1982623002/ )
>
> Reason for revert:
> This broke the downstream clang-clankium-tot-builder, since PersonalDataManager at least is used by downstream autofill code to get profiles and credit cards: https://goto.google.com/kneae
>
> Original issue's description:
> > Sorted the profiles and credit cards to be used in PaymentRequest.
> >
> > Also added test methods to set the use count and use date of profiles and cards.
> >
> > BUG= 609864 
> > TEST=PersonalDataManagerTestJava
> >
> > Committed: https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2
> > Cr-Commit-Position: refs/heads/master@{#397562}
>
> TBR=mathp@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,sebsg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 609864 
>
> Committed: https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e
> Cr-Commit-Position: refs/heads/master@{#397679}

TBR=mathp@chromium.org,dfalcantara@chromium.org,sebsg@chromium.org,johnme@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 609864 

Review-Url: https://codereview.chromium.org/2039493002
Cr-Commit-Position: refs/heads/master@{#397721}

[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/6d4d84bd31ae2320fa22efe02d69e2dd3803c2d3/components/autofill/core/browser/personal_data_manager_unittest.cc

Copying from the other bug (issue 617129): Since this broke our clank ToT builders and the patch included changes to Android specifically, I think reverting was an okay course of action (although the downstream fix did end up being simple). I'm okay with the revert of the revert followed in quick succession by a fix.

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/71ec2a7218cd78d345164c6d6b5a7a794e3b428c

commit 71ec2a7218cd78d345164c6d6b5a7a794e3b428c
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Jun 03 16:42:17 2016

Thank you for the clarification. I was not aware that Clankium tracks Chromium this closely. I will attempt to submit both Chromium and Clankium changes at about the same time in the future.