New issue
Advanced search Search tips

Issue 609851 link

Starred by 3 users
Status: Fixed
Owner:
liber...@chromium.org
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

adjust media UI based on actual width

Project Member Reported by liber...@chromium.org, May 6 2016 
now that the play button is always visible, we can rely on the computed style to figure out its width.  we should use that, rather than hardcoding the width at the mobile size (48px).
Project Member

Comment 1 by bugdroid1@chromium.org, May 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2ca18bc9b7f46aff95987ffbc612cb3c7ae1eb2

commit b2ca18bc9b7f46aff95987ffbc612cb3c7ae1eb2
Author: liberato <liberato@chromium.org>
Date: Fri May 13 16:22:06 2016

Use media controls play button's width rather than hard-coded 48px.

Previously, when computing which controls fit on the media panel, we
would use 48px for the android UI.  Desktop uses 32px.  Since the
play button is always visible, and thus will have a computed style
once layout happens, we'll now use that.

BUG= 609851 

Review-Url: https://codereview.chromium.org/1948363004
Cr-Commit-Position: refs/heads/master@{#393540}

[modify] https://crrev.com/b2ca18bc9b7f46aff95987ffbc612cb3c7ae1eb2/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Comment 2 by liber...@chromium.org, May 13 2016

Status: Fixed (was: Started)
►

Sign in to add a comment