Android Find in Page field has wrong inputType |
||
Issue descriptionCopied from b/28545733. Steps to reproduce: (1) Make sure you're using the Google Keyboard. (2) Visit any page. (3) Choose Find in page from the menu. (4) Try to type a word using a gesture (swipe through the letters). Expected result: Word is inputted. Actual result: Gesture typing is disabled on this input field. According to b/28545733, this is because the Find in Page query field has NULL inputType, and hence the Google Keyboard assumes it might be a password field. That's odd, because ever since Find in Page was first added in commit f1374e1532c13fd9550bd92391c548aa6e0b1daf in the clank repository, the inputType has been set to InputType.TYPE_TEXT_VARIATION_FILTER. Today this is done at https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java&l=217
,
May 6 2016
,
May 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/248caf490f70600ba98228fce15b7046efcfeb74 commit 248caf490f70600ba98228fce15b7046efcfeb74 Author: johnme <johnme@chromium.org> Date: Sat May 07 12:30:54 2016 Fix Android Find in Page inputType to allow gesture input Chrome has always set the inputType to TYPE_TEXT_VARIATION_FILTER, which is invalid. Instead we should be setting it to InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_FILTER. BUG= 609847 TEST=manually verified Review-Url: https://codereview.chromium.org/1953273003 Cr-Commit-Position: refs/heads/master@{#392254} [modify] https://crrev.com/248caf490f70600ba98228fce15b7046efcfeb74/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java
,
May 9 2016
,
May 10 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by joh...@chromium.org
, May 6 2016Status: Started (was: Untriaged)