New issue
Advanced search Search tips

Issue 609846 link

Starred by 2 users
Status: Fixed
Owner:
ekaramad@chromium.org
Closed: Jan 2017
Cc:
kenrb@chromium.org
wjmaclean@chromium.org
creis@chromium.org
mknowles@chromium.org
lfg@chromium.org
mcnee@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 578168


Sign in to add a comment

Implement TextInputState and IME for OOPIF-<webview>

Project Member Reported by ekaramad@chromium.org, May 6 2016 
This bug is to track the progress on IME implementation for OOPIF-based <webview>. TextInputState tracking logic will be resolved, for the most part, after resolving  issue 578168 . This bug will address the interaction between the inner and outer WebContents, specifically during attaching and detaching.

Comment 1 by ekaramad@chromium.org, Aug 22 2016

Cc: mknowles@chromium.org
Components: -Internals>Sandbox>SiteIsolation
Labels: -Pri-2 OS-All Pri-1
IME seems to be working fine on Aura-Linux/Windows when passing --use-cross-process-frames-for-guests. I will keep this bug as the tracking bug for <webview>-IME.

Comment 2 by ekaramad@chromium.org, Jan 17 2017

Cc: wjmaclean@chromium.org creis@chromium.org
Status: Fixed (was: Assigned)
I just verified this on all of Mac, Linux, Windows, and ChromeOS platforms. IME seems to work fine (perhaps as far away back as Chrome 55). Closing the bug.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c179dc03b3db05f4a5726649171eb32a7d748f04

commit c179dc03b3db05f4a5726649171eb32a7d748f04
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Sat Dec 15 03:09:29 2018

GuestView: No TextInputManager when unattached

 TextInputManager is created lazily the first time GetTextInputManager
is called on WebContents. Given that TextInputManager should only exist
for the outermost WebContents, there is no point in creating it for an
unattach guest WebContents only to clear it after attaching. Also, it
seems incorrect to try to access |text_input_manager_| for an unattached
guest WebContents.

Bug:  609846 
Change-Id: I0b60a0a3160909f9d8c0b6a4c099c3f4769af0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1376090
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616934}
[modify] https://crrev.com/c179dc03b3db05f4a5726649171eb32a7d748f04/content/browser/web_contents/web_contents_impl.cc
►

Sign in to add a comment