Probably, commented on issue https://codereview.chromium.org/1927773002/#msg46

We could probably just remove the refactoring I commented on for backwards-compat.

I'm hitting this as well.

i miss Google too much. I'm serious. So, let's see.

Context: this line calls private method of a module. Seriously, why? :(

https://chromium.googlesource.com/chromium/src/+/master/PRESUBMIT.py#1071

depot_tools CL: https://codereview.chromium.org/1955223002

chromium CL: https://codereview.chromium.org/1955993004 must land after depot_tools. And my plane is taking off. Timely :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/830dc0bca87a4a831cb80407f4e0b6e3c082ec08

commit 830dc0bca87a4a831cb80407f4e0b6e3c082ec08
Author: tandrii@chromium.org <tandrii@chromium.org>
Date: Mon May 09 06:26:34 2016

Properly expose already used elsewhere functionality.

Also make _RietveldOwnerAndReviewers have same semantics as before,
to resolve immediate bug until chromium checkouts of developers are
updated.

BUG= 609832 
R=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/1955223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300494 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/830dc0bca87a4a831cb80407f4e0b6e3c082ec08/presubmit_canned_checks.py
[modify] https://crrev.com/830dc0bca87a4a831cb80407f4e0b6e3c082ec08/tests/presubmit_unittest.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/4dd6f254720ebfbc02a98c38354023e04e1a3d87

commit 4dd6f254720ebfbc02a98c38354023e04e1a3d87
Author: recipe-roller@chromium.org <recipe-roller@chromium.org>
Date: Mon May 09 06:35:36 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/830dc0bca87a4a831cb80407f4e0b6e3c082ec08 Properly expose already used elsewhere functionality. (tandrii@chromium.org)

R=machenbach@chromium.org,tandrii@chromium.org
BUG= 609832 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1961783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300495 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/4dd6f254720ebfbc02a98c38354023e04e1a3d87/infra/config/recipes.cfg

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87591

------------------------------------------------------------------
r87591 | recipe-roller@chromium.org | 2016-05-09T06:43:14.838211Z

-----------------------------------------------------------------

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed3b7e17bdcb3ec8ee0655db7227461476c1f9c8

commit ed3b7e17bdcb3ec8ee0655db7227461476c1f9c8
Author: tandrii <tandrii@chromium.org>
Date: Thu May 12 14:38:50 2016

Fix PRESUBMIT.py erros on uploading DEPS change.

Depends on depot_tools change https://codereview.chromium.org/1955223002,
so if you think this broke you, please update depot_tools by just running
gclient with no arguments.

R=machenbach@chromium.org
BUG= 609832 
nOTRY=true

Review-Url: https://codereview.chromium.org/1955993004
Cr-Commit-Position: refs/heads/master@{#393243}

[modify] https://crrev.com/ed3b7e17bdcb3ec8ee0655db7227461476c1f9c8/PRESUBMIT.py