New issue
Advanced search Search tips

Issue 609813 link

Starred by 3 users
Status: Fixed
Owner:
drott@chromium.org
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

Support font-variant-numeric

Project Member Reported by drott@chromium.org, May 6 2016 
(See http://www.chromium.org/blink#launch-process for an overview)

Change description:
Add support for font-variant-numeric and respective mapping from the font: CSS shorthand and into the font-variant: shorthand.

Changes to API surface:
Additional CSS property font-variant-numeric

Links:
Public standards discussion: https://drafts.csswg.org/css-fonts/#font-variant-numeric-prop

Support in other browsers:
Internet Explorer: Not supported
Firefox: since 34
Safari: Nightlies and iOS 9.3 Beta

Comment 1 by drott@chromium.org, May 12 2016 

Intent to Implement and Ship posted and LGTM'ed on blink-dev:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/osZzOCF-ONM
Project Member

Comment 2 by bugdroid1@chromium.org, May 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/922e9b6aab1704df01ff8a03212a85e53a360e4b

commit 922e9b6aab1704df01ff8a03212a85e53a360e4b
Author: drott <drott@chromium.org>
Date: Fri May 13 16:03:16 2016

Implement font-variant-numeric

Now that we have font-variant converted to be a shorthand, we can base
an implementation of font-variant-numeric on top.

This CL implements the font-variant-numeric property, integrates it with
the font-variant shorthand, implements the required OpenType mappings
and activates the feature in HarfBuzz as needed. Tests added and
extended accordingly.

Intent to Implement and Ship thread on blink-dev:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/osZzOCF-ONM

BUG= 609813 

Review-Url: https://codereview.chromium.org/1955723004
Cr-Commit-Position: refs/heads/master@{#393534}

[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/css/font-property-priority-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/css/font-shorthand-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/css/font-shorthand-from-longhands.html
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/css/font-variant-shorthand-from-longhands-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/css/font-variant-shorthand-from-longhands.html
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/inspector-support/style-expected.txt
[add] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-numeric-expected.html
[add] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-numeric.html
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-shorthand.html
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/fast/text/font-features/resources/font-variant-features.js
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/inspector/console/console-format-style-whitelist-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-properties-overload-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/CSSProperties.in
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/CSSValueKeywords.in
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/resolver/CSSPropertyPriority.h
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/resolver/FontBuilder.h
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/resolver/FontBuilderTest.cpp
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/platform/fonts/FontDescription.cpp
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/platform/fonts/FontDescription.h
[add] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/platform/fonts/FontVariantNumeric.h
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/922e9b6aab1704df01ff8a03212a85e53a360e4b/tools/metrics/histograms/histograms.xml

Comment 3 by drott@chromium.org, May 16 2016

Status: Fixed (was: Started)
►

Sign in to add a comment