Version: 52.0.2726.0 OS: Mac What steps will reproduce the problem? (1) Visit https://w3c.github.io/webappsec/demos/credential-management/ (2) Save one account and sign out. (3) Visit https://w3c.github.io/webappsec/demos/credential-management/ again and press "Sign in". What is the expected output? The account chooser should close on pressing ESC. It work on Windows. What do you see instead? ESC has no effect.
Thanks a lot Vasilii! I'd increase the priority though since users should be able to continue interacting with the site also if they really don't want to make a decision on the dialog.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d237e3b85e855b9620ba3e94df06095ad3ecc07 commit 4d237e3b85e855b9620ba3e94df06095ad3ecc07 Author: vasilii <vasilii@chromium.org> Date: Mon May 09 12:13:24 2016 Close the account chooser and auto sign-in opt in with ESC on Mac. BUG= 609810 Review-Url: https://codereview.chromium.org/1961023002 Cr-Commit-Position: refs/heads/master@{#392298} [modify] https://crrev.com/4d237e3b85e855b9620ba3e94df06095ad3ecc07/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm [modify] https://crrev.com/4d237e3b85e855b9620ba3e94df06095ad3ecc07/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm [modify] https://crrev.com/4d237e3b85e855b9620ba3e94df06095ad3ecc07/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm [modify] https://crrev.com/4d237e3b85e855b9620ba3e94df06095ad3ecc07/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller_unittest.mm
I'd like to merge r392298 back. It's a usability issue. The fix isn't complicated.
Your change meets the bar and is auto-approved for M51 (branch: 2704)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1495d2f4d6126125e42fbe3a86719f65feeed01 commit a1495d2f4d6126125e42fbe3a86719f65feeed01 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Tue May 10 11:52:16 2016 Close the account chooser and auto sign-in opt in with ESC on Mac. BUG= 609810 Review-Url: https://codereview.chromium.org/1961023002 Cr-Commit-Position: refs/heads/master@{#392298} (cherry picked from commit 4d237e3b85e855b9620ba3e94df06095ad3ecc07) Review URL: https://codereview.chromium.org/1968463002 . Cr-Commit-Position: refs/branch-heads/2704@{#468} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/a1495d2f4d6126125e42fbe3a86719f65feeed01/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm [modify] https://crrev.com/a1495d2f4d6126125e42fbe3a86719f65feeed01/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm [modify] https://crrev.com/a1495d2f4d6126125e42fbe3a86719f65feeed01/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm [modify] https://crrev.com/a1495d2f4d6126125e42fbe3a86719f65feeed01/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d141f6fff8b47d89818867f6f4fd6bbda174daf commit 4d141f6fff8b47d89818867f6f4fd6bbda174daf Author: vasilii <vasilii@chromium.org> Date: Thu May 19 08:38:15 2016 Remove debug code from the autosign-in first run on Mac. https://codereview.chromium.org/1961023002 introduced it. However, I was just experimenting with the approach. It didn't work well. Therefore, the block was landed by mistake. BUG= 609810 Review-Url: https://codereview.chromium.org/1991893002 Cr-Commit-Position: refs/heads/master@{#394717} [modify] https://crrev.com/4d141f6fff8b47d89818867f6f4fd6bbda174daf/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm
Comment 1 by sabineb@chromium.org
, May 7 2016Labels: -Pri-3 M-51 Pri-1