New issue
Advanced search Search tips

Issue 609808 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove deprecated V8 weakness type.

Project Member Reported by u...@chromium.org, May 6 2016

Issue description

V8 weak handles that use WeakCallbackData were deprecated. The embedders should use WeakCallbackInfo instead.

This issue tracks CLs that remove WeakCallbackData.
 
Project Member

Comment 3 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/82dcb2beeeb85369902c76e48374caed4fac58fb

commit 82dcb2beeeb85369902c76e48374caed4fac58fb
Author: ulan <ulan@chromium.org>
Date: Fri May 06 13:17:43 2016

[API] Remove deprecated WeakCallbackData and related functions.

This removes:
- PersistentBase::SetWeak that takes WeakCallbackData.
  The embedders should use the version that takes WeakCallbackInfo.
- PersistentBase::SetPhantom.
  The embedders should SetWeak that takes WeakCallbackInfo.

Functions in DefaultPersistentValueMapTraits are changed to accept
WeakCallbackInfo instead of WeakCallbackData.

BUG= chromium:609808 
LOG=NO

Review-Url: https://codereview.chromium.org/1953263002
Cr-Commit-Position: refs/heads/master@{#36079}

[modify] https://crrev.com/82dcb2beeeb85369902c76e48374caed4fac58fb/include/v8-util.h
[modify] https://crrev.com/82dcb2beeeb85369902c76e48374caed4fac58fb/include/v8.h
[modify] https://crrev.com/82dcb2beeeb85369902c76e48374caed4fac58fb/src/api.cc
[modify] https://crrev.com/82dcb2beeeb85369902c76e48374caed4fac58fb/src/global-handles.cc
[modify] https://crrev.com/82dcb2beeeb85369902c76e48374caed4fac58fb/src/global-handles.h
[modify] https://crrev.com/82dcb2beeeb85369902c76e48374caed4fac58fb/src/profiler/allocation-tracker.cc
[modify] https://crrev.com/82dcb2beeeb85369902c76e48374caed4fac58fb/src/profiler/allocation-tracker.h

Comment 4 by u...@chromium.org, May 6 2016

Status: Fixed (was: Assigned)

Sign in to add a comment