New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609780 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 609765
Owner:
Last visit > 30 days ago
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

26.5% regression in smoothness.tough_filters_cases at 391706:391768

Project Member Reported by alexclarke@chromium.org, May 6 2016

Issue description

Probably a duplicate.  Lets see what the bot finds.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=609780

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgtMy8tgkM


Bot(s) for this bug's original alert(s):

android-galaxy-s5
Mergedinto: 609765
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : cc: optimize filter backing store texture allocation.
Author  : senorblanco
Commit description:
  
The backing store used for filters in cc is determined by the
primitive bounds, and the filter outsets. This means that
we may end up allocating many textures of different sizes,
defeating Skia's texture cache. Texture allocation can be
slow, so we can ameliorate the allocation pressure by
rounding width and height up to the nearest power of 2.
(This is what Skia does internally for scratch textures).

BUG= 602785 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1884553003
Cr-Commit-Position: refs/heads/master@{#391753}
Commit  : d47a9ef38a0c81f0250e575f08fb47fb56fe1d66
Date    : Thu May 05 04:29:08 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@391705  679.532  23.2099  8  good
chromium@391737  655.813  23.5699  5  good
chromium@391745  646.962  31.5981  8  good
chromium@391749  672.385  24.7195  8  good
chromium@391751  666.192  26.9627  5  good
chromium@391752  668.979  21.9824  5  good
chromium@391753  777.407  62.3748  5  bad    <--
chromium@391768  753.295  58.7033  8  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 609780

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.tough_filters_cases
Test Metric: frame_times/http___rawgit.com_WebKit_webkit_master_PerformanceTests_Animometer_developer.html?test-interval_20_display_minimal_controller_fixed_frame-rate_50_kalman-process-error_1_kalman-measurement-error_4_time-measurement_performance_suite-name_Animometer_test-name_Focus_complexity_100
Relative Change: 10.81%
Score: 98.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/646
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013418942739635904


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5775299287973888

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : cc: optimize filter backing store texture allocation.
Author  : senorblanco
Commit description:
  
The backing store used for filters in cc is determined by the
primitive bounds, and the filter outsets. This means that
we may end up allocating many textures of different sizes,
defeating Skia's texture cache. Texture allocation can be
slow, so we can ameliorate the allocation pressure by
rounding width and height up to the nearest power of 2.
(This is what Skia does internally for scratch textures).

BUG= 602785 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1884553003
Cr-Commit-Position: refs/heads/master@{#391753}
Commit  : d47a9ef38a0c81f0250e575f08fb47fb56fe1d66
Date    : Thu May 05 04:29:08 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@391700  675.83   33.5366  5  good
chromium@391745  678.224  13.73    5  good
chromium@391751  661.125  27.2495  8  good
chromium@391752  667.032  33.4981  8  good
chromium@391753  791.529  110.975  8  bad    <--
chromium@391754  769.686  45.2735  5  bad
chromium@391757  822.603  41.9698  5  bad
chromium@391768  780.473  54.1988  5  bad
chromium@391790  771.559  40.0811  8  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 609780

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.tough_filters_cases
Test Metric: frame_times/http___rawgit.com_WebKit_webkit_master_PerformanceTests_Animometer_developer.html?test-interval_20_display_minimal_controller_fixed_frame-rate_50_kalman-process-error_1_kalman-measurement-error_4_time-measurement_performance_suite-name_Animometer_test-name_Focus_complexity_100
Relative Change: 15.61%
Score: 98.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/647
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013418925637791120


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5823835639644160

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment