New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609774 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 609517
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

42.1% regression in tab_switching.typical_25 at 391672:391722

Project Member Reported by alexclarke@chromium.org, May 6 2016

Issue description

This is probably a duplicate since if something is taking up a lot of thread time that's likely to impact this metric too.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=609774

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg1OOcugoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-hdd

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@391671  2528.63  1046.44  8  good
chromium@391722  2512.13  761.095  8  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 609774

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.typical_25
Test Metric: idle_wakeups_total/idle_wakeups_total
Relative Change: 36.34%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/528
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013419400446969568


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5838760986542080

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Trying again.

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@391671  2917.29  712.432  7  good
chromium@391722  2662.0   286.087  7  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 609774

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.typical_25
Test Metric: idle_wakeups_total/idle_wakeups_total
Relative Change: 8.57%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/529
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013419390356706832


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5870353692229632

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@391671  2540.28  198.545  18  good
chromium@391722  2543.17  227.158  18  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 609774

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.typical_25
Test Metric: idle_wakeups_total/idle_wakeups_total
Relative Change: 6.05%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/535
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013385496985161280


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5320373466300416

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: bruthig@chromium.org
I notice r391722 was found twice by which is  https://codereview.chromium.org/1949143003 a bit surprising.

+bruthig is it possible your patch could have impacted this metric?

I've kicked off a third wider bisect with more iterations, which should help clarify.
Mergedinto: 609517
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : This change enables GPU Raster on OSX.
Author  : ericrk
Commit description:
  
I've compiled a bit of benchmark data to support turning this on -
https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo7ilx9KDB_nJnwpc/edit?usp=sharing
Still filling in more data, but I'm pretty happy with the results so far. In
a number of cases we have a performance win, and in most cases we have a power win.

Checking this in now will give us a long canary period before the next branch
point to catch any issues.

BUG= 542959 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.blink:mac_blink_rel

Review-Url: https://codereview.chromium.org/1881053003
Cr-Commit-Position: refs/heads/master@{#391655}
Commit  : 8325892c2efdef8cff86ba16e7569f8b424daeda
Date    : Wed May 04 22:14:40 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@391400  1905.4  90.1377  5  good
chromium@391600  1698.8  132.177  5  good
chromium@391650  1735.8  91.0148  5  good
chromium@391654  1783.6  193.945  5  good
chromium@391655  2585.8  242.841  5  bad    <--
chromium@391656  2616.0  199.573  5  bad
chromium@391657  2662.4  162.769  5  bad
chromium@391663  2686.0  324.218  5  bad
chromium@391675  2532.6  268.226  5  bad
chromium@391700  2550.4  122.157  5  bad
chromium@391800  2644.6  226.414  5  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 609774

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.typical_25
Test Metric: idle_wakeups_total/idle_wakeups_total
Relative Change: 38.80%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/537
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013152486220616448


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5839670110322688

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment