Issue metadata
Sign in to add a comment
|
10.9% regression in smoothness.tough_filters_cases at 391741:391756 |
||||||||||||||||||||
Issue descriptionSomewhat noisy graph. Might be a duplicate of https://bugs.chromium.org/p/chromium/issues/detail?id=609763. Lets see what the bisect finds.
,
May 6 2016
=== Auto-CCing suspected CL author senorblanco@chromium.org === Hi senorblanco@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : cc: optimize filter backing store texture allocation. Author : senorblanco Commit description: The backing store used for filters in cc is determined by the primitive bounds, and the filter outsets. This means that we may end up allocating many textures of different sizes, defeating Skia's texture cache. Texture allocation can be slow, so we can ameliorate the allocation pressure by rounding width and height up to the nearest power of 2. (This is what Skia does internally for scratch textures). BUG= 602785 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1884553003 Cr-Commit-Position: refs/heads/master@{#391753} Commit : d47a9ef38a0c81f0250e575f08fb47fb56fe1d66 Date : Thu May 05 04:29:08 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@391740 47.9299 1.37841 5 good chromium@391749 47.1145 0.954746 5 good chromium@391751 46.7525 1.41045 5 good chromium@391752 46.2989 0.812588 5 good chromium@391753 51.7448 1.5612 5 bad <-- chromium@391756 52.7035 1.73582 5 bad Bisect job ran on: winx64nvidia_perf_bisect Bug ID: 609765 Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.tough_filters_cases Test Metric: frame_times/http___rawgit.com_WebKit_webkit_master_PerformanceTests_Animometer_developer.html?test-interval_20_display_minimal_controller_fixed_frame-rate_50_kalman-process-error_1_kalman-measurement-error_4_time-measurement_performance_suite-name_Animometer_test-name_Focus_complexity_100 Relative Change: 9.96% Score: 99.8 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1628 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013420321721180064 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5221256358526976 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 6 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : cc: optimize filter backing store texture allocation. Author : senorblanco Commit description: The backing store used for filters in cc is determined by the primitive bounds, and the filter outsets. This means that we may end up allocating many textures of different sizes, defeating Skia's texture cache. Texture allocation can be slow, so we can ameliorate the allocation pressure by rounding width and height up to the nearest power of 2. (This is what Skia does internally for scratch textures). BUG= 602785 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1884553003 Cr-Commit-Position: refs/heads/master@{#391753} Commit : d47a9ef38a0c81f0250e575f08fb47fb56fe1d66 Date : Thu May 05 04:29:08 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@391740 46.0958 1.6247 5 good chromium@391749 46.6219 0.530493 8 good chromium@391751 45.4519 1.69628 8 good chromium@391752 46.0298 0.556215 5 good chromium@391753 50.2598 1.63427 8 bad <-- chromium@391756 51.1492 0.314395 5 bad Bisect job ran on: winx64nvidia_perf_bisect Bug ID: 609765 Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.tough_filters_cases Test Metric: frame_times/http___rawgit.com_WebKit_webkit_master_PerformanceTests_Animometer_developer.html?test-interval_20_display_minimal_controller_fixed_frame-rate_50_kalman-process-error_1_kalman-measurement-error_4_time-measurement_performance_suite-name_Animometer_test-name_Focus_complexity_100 Relative Change: 10.96% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1629 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013420308564677296 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5787279562375168 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 6 2016
Since this change is a win on Win Intel, Retina Mac, and other platforms, I'm going to say we'll eat this loss and make it up elsewhere on all platforms. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by alexclarke@chromium.org
, May 6 2016