Regression: [DevTools] 'Shift + drag' action is not smooth for '3D Device model' in 'Sensors' section.
Reported by
dchau...@etouch.net,
May 6 2016
|
||||||||||
Issue descriptionChrome Version: 52.0.2726.0 (Official Build)58a611fea9de21de789f594b0e95c5147d74b519-refs/heads/master@{#391959} 32/64-bit. OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(Ubuntu 14.04 LTS). What steps will reproduce the problem? 1. Launch chrome, open 'DevTools' window and press 'Esc' key to open console drawer window. 2. Go to 'Sensors' section and select 'Portrait' or any Presets from 'Accelerometer' drop down list. 3. Now try to rotate the '3D Device model' around z-axis using 'Shift + drag' and observe. Rotating action is not smooth. Rotating action should be smooth. This is a regression issue, broken from M-52 series, below is bisect info. Manual regression range: Good Build : 52.0.2725.0 Bad Build : 52.0.2726.0 Narrow Bisect info: https://chromium.googlesource.com/chromium/src/+log/14e531148a3f0164a49736e0bdea175b152f05f9..d8a506c092f85ee69272136f0b4e3af915a09f39?pretty=fuller&n=10000 Suspecting : r391863 Kindly review the attached screen-cast for reference.
,
May 10 2016
@calamity: Hey, would you mind checking the above issue as per above details ? This issue is still reproducible on 52.0.2730.0. I really appreciate your help. Thank you!
,
May 10 2016
CL: https://codereview.chromium.org/1956783003/ Thanks for reporting, I should get in the habit of marking issues as 'started' when there is a CL in review. The CL above will keep dragging behavior the same, but update the tooltip message to say "Shift+drag horizontally to rotate around the y-axis", which should make it clearer that only horizontal movement will work with shift.
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d89d2e4eab43767b7180726950675b4df394d28 commit 9d89d2e4eab43767b7180726950675b4df394d28 Author: luoe <luoe@chromium.org> Date: Thu May 12 22:03:21 2016 DevTools: fix styling for 3D phone preview inn sensors drawer This CL depends on: DevTools: fix incorrect device orientation bug https://codereview.chromium.org/1952283004/ BUG= 609753 , 609706 , 609703 Review-Url: https://codereview.chromium.org/1956783003 Cr-Commit-Position: refs/heads/master@{#393370} [modify] https://crrev.com/9d89d2e4eab43767b7180726950675b4df394d28/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js [modify] https://crrev.com/9d89d2e4eab43767b7180726950675b4df394d28/third_party/WebKit/Source/devtools/front_end/emulation/sensors.css
,
May 13 2016
,
Sep 28 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-52; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-52 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 28 2016
[Bulk edit] Our blockerbot script was offline; it was recently brought back online, and thus labeled many old issues (including this one) erroneously. Removing Merge-TBD label since all milestones for this issue are already completed; no further work should be done. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by msrchandra@chromium.org
, May 6 2016