New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609740 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Page fails to notice autofilled password

Reported by thrustma...@gmail.com, May 6 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.94 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. Goes to Justacote.com
2. Try to connect with auto complete password when it's saved by Chrome (yellow field)
3. Js return error. Password field is not empty but js says it is.

What is the expected behavior?

What went wrong?
When I try to connect with Chrome on my website, Justacote, the Chrome auto fill when password is saved return an empty field. So it can't connect until I write manually the password. 

Does it occur on multiple sites: N/A

Is it a problem with a plugin? N/A 

Did this work before? Yes It was working on chrome 49

Does this work in other browsers? Yes 

Chrome version: 50.0.2661.94  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 21.0 r0
 
Sans titre.png
69.5 KB View Download
It happens because we are opening login form on jquery windows. Any solution?
Can you check Chrome Developer Tools (Ctrl+Shift+I) for an error message that may provide you with more details about the error?
Hello,

Chrome error console does not return an error.
Cc: kavvaru@chromium.org
Components: UI>Browser>Passwords
Labels: -Type-Compat M-50 hasbisect OS-Linux OS-Mac Type-Bug-Regression
Owner: a...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.4 using chrome version 50.0.2661.102 with the below steps

1.Login to Justacote.com site and saved the password when offered.log out.
2.try to login with autofilled values and observe the error and unable to login to site.
3.But observed the password saved to chrome://settings/managepasswords

Note::Not seen the password save bubble for chrome beta(51.0.2704.36) and canary version(52.0.2733.0)

This is regression issue broken in M50.Please find the bisect information as below

Narrow Bisect::
Good::50.0.2628.0  --  (official build 370939)
Bad:: 50.0.2629.0  --  (official build 371142)

CHANGELOG URL:  https://chromium.googlesource.com/chromium/src/+log/73762d7a5510e9712223b351288497778460fa4b..f92f4e5c849c028db73fbe06912685a77b978ee4

Unable to find the exact suspect thought suspecting this might be ralted to below change
https://chromium.googlesource.com/chromium/src/+/b3b47ab25d16ae178cd926495681205bc6285a4c

avi@ Could you please look into this issue if it is related to your change,else please help us in finding the appropriate owner for this issue.

Thanks,

Comment 5 by a...@chromium.org, May 12 2016

Cc: a...@chromium.org
Components: UI>Browser>Autofill
Owner: isherman@chromium.org
Status: Untriaged (was: Assigned)
That suspect change was reverted and is not present in 50.0.2661.102. If you are reproducing with 50.0.2661.102 then it isn't me.

Rerouting to autofill, picking an owner from OWNERS.

Comment 6 by ma...@chromium.org, May 12 2016

Cc: -kavvaru@chromium.org ma...@chromium.org
Owner: kavvaru@chromium.org
kavvaru@ as indicated in #5 can you try to repro in a later version such as 50.0.2661.102?

Comment 7 by a...@chromium.org, May 12 2016

Cc: kavvaru@chromium.org
Owner: ma...@chromium.org
mathp,

kavvaru said in comment 4 that he reproduced it in 50.0.2661.102: "Able to reproduce the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.4 using chrome version 50.0.2661.102"

Comment 8 by ma...@chromium.org, May 12 2016

Owner: se...@chromium.org
Status: Assigned (was: Untriaged)
Sorry, I missed that. 

+sebsg@

Comment 9 by vabr@chromium.org, May 13 2016

Cc: vabr@chromium.org
Also reproducible on 52.0.2736.0 (Developer Build) (64-bit) on GNU/Linux.

sebsg@, do you think adding sending the events as you did for other autofill code would be a good fix here?

Comment 10 by se...@chromium.org, May 13 2016

Yes, I realize now that I started typing a comment but forgot to send it. I think what you suggest might work. Original message:

Hi, I was able to reproduce and it seems to me like the site is waiting on some specific event for validation. For example, if I click on the username field, the password field becomes empty. I recently added the code to send some event when we autofill address and credit card forms, I'll try to see if it fixes this too.

Comment 11 by se...@chromium.org, May 19 2016

After investigation, it seems the problem is with the user gestures. The password is never actually filled in field, only suggested. I still think we should add the events when we fill passwords but it will not fix this bug.

The problem might happen because the login is in a modal view? OnUserGesture is never triggered after the modal has appeared.

Comment 12 by vabr@chromium.org, May 24 2016

Components: -UI>Browser>Autofill
Labels: Hotlist-Polish
Thanks for the investigation, sebsg@!

Indeed, while we should add the events, they are not fixing this case, when the value never gets promoted from suggested to a JS-visible one.

It is interesting -- clicking in the iframe does not unblock the value, but trigering filling from the username again does.

There is possibly a bug in the password-only code, and it is not connected to sending the events, so please feel free to drop the ownership, if you don't want to look into it (just disown and mark as Available).
Hi Devs,

Any timeline on this issue? 

Addendum to the problem: This happens only when you open the popup and the values are pre-filled. If you clear the values and re-use the auto fill option by starting to type the username. In that case the login is successful.

/Amarjit
Cc: se...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Marked as available because my plate is pretty full these days. In case anyone wants to look at it in the meantime otherwise I'll take a look again when I'm more available.

Comment 15 by vabr@chromium.org, Jun 7 2016

Labels: -M-50 -Pri-2 -Type-Bug-Regression Pri-3 Type-Bug
Regarding time estimates: there are and will be none. It is in our queue of bugs to fix, once someone gets to it, this report will get updated.

(Also removing the milestone and reclassifying this as a non-regression, because the blamelist looks unrelated.)

Comment 16 by vabr@chromium.org, Jun 7 2016

Summary: Page fails to notice autofilled password (was: Password auto fill is empty)

Comment 17 by vabr@chromium.org, Jun 7 2016

Cc: -vabr@chromium.org
The Javascipt sees an empty password. For some reason the password isn't accessible to the site after autofilling.

Comment 19 by kolos@chromium.org, Apr 11 2017

Status: Fixed (was: Available)
Re-tested. It works. This CL probably fixed it (https://codereview.chromium.org/2750323003/)
It is still reproducible in the 58.0.3029.110 (64-bit) build of chrome

Comment 21 by a...@chromium.org, Jun 1 2017

Probably worth filing a new bug.

Sign in to add a comment