New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609718 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] '3D Device model' rotates to 360 degree instead of 1 degree in 'sensors' section.

Reported by dchau...@etouch.net, May 6 2016

Issue description

Chrome Version: 52.0.2726.0 (Official Build)58a611fea9de21de789f594b0e95c5147d74b519-refs/heads/master@{#391959} 32/64-bit.
OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(Ubuntu 14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, open 'DevTools' and press 'Esc' key to open console drawer.
2. Go to 'Sensors' section and select 'Portrait upside down' from 'Accelerometer' drop down list.
3. Now keep focus on 'alpha' textbox(default count is 180 degree.
4. Press down arrow from keyboard to reduce count by 1 degree (i.e. 179 degree) and observe '3D Device model'.

'3D Device model' rotates to 360 degree instead of 1 degree.
'3D Device model' should rotate by 1 degree.

This is a regression issue, broken in M-52 series, will soon update other info.
 
Labels: hasbisect
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Good build: 52.0.2718.0 
Bad build:  52.0.2719.0 

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/33b3cd875c5498abb636d472136b58606902b1be..4b13c18950dd930908dfc9ec83dccb980338e293?pretty=fuller&n=10000

Suspecting: r390131

Kindly review the attached screen-cast for reference.
Actual_behavior.mp4
1.0 MB Download
Expected_behavior.mp4
842 KB Download
Labels: ReleaseBlock-Stable
Adding Release Block as this is a recent Regression. Please remove if not required.
Thank You.

Comment 3 by l...@chromium.org, May 6 2016

I'm not sure whether we can control the "direction" of a 3D rotation.  I will check with the blink team in another ticket and see if this is possible:
https://bugs.chromium.org/p/chromium/issues/detail?id=610014

Comment 4 by l...@chromium.org, May 9 2016

Components: Blink>CSS>3D
@Blink>CSS>3d: I filed a separate issue related to this behavior: https://bugs.chromium.org/p/chromium/issues/detail?id=610014

Could you please check it out and see if there's some way for 3D rotation animations to take the direction of the shortest path?
dchaubey@ - Friendly reminder, Could you please respond for the comment #4.

Comment 6 by l...@chromium.org, May 12 2016

Status: Started (was: Assigned)
CL: https://codereview.chromium.org/1975723003/

A CL has been started.

Comment 8 by l...@chromium.org, May 19 2016

The landed CL didn't fix this:
https://codereview.chromium.org/1975723003/

But a new CL, in review, should:
https://codereview.chromium.org/1996013004/
Project Member

Comment 9 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df711c5bbb88cd9be9853f011c6288fb4c8a0914

commit df711c5bbb88cd9be9853f011c6288fb4c8a0914
Author: luoe <luoe@chromium.org>
Date: Thu May 19 21:15:41 2016

DevTools: better SensorsView orientation fix

It's my fault for landing a patch that didn't actually fix the bug: https://codereview.chromium.org/1975723003/

This CL should 'actually' do the correct behavior, since the transform now does not depend on a WebKitCSSMatrix.

BUG= 609718 

Review-Url: https://codereview.chromium.org/1996013004
Cr-Commit-Position: refs/heads/master@{#394864}

[modify] https://crrev.com/df711c5bbb88cd9be9853f011c6288fb4c8a0914/third_party/WebKit/LayoutTests/inspector/components/geometry-expected.txt
[modify] https://crrev.com/df711c5bbb88cd9be9853f011c6288fb4c8a0914/third_party/WebKit/Source/devtools/front_end/common/Geometry.js
[modify] https://crrev.com/df711c5bbb88cd9be9853f011c6288fb4c8a0914/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js

Comment 10 by l...@chromium.org, May 20 2016

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-52; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-52 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
[Bulk edit]

Our blockerbot script was offline; it was recently brought back online, and thus labeled many old issues (including this one) erroneously.  Removing Merge-TBD label since all milestones for this issue are already completed; no further work should be done.

Comment 13 by suzyh@chromium.org, Mar 24 2017

Components: -Blink>CSS>CSS3D Blink>Compositing>Transform3D

Sign in to add a comment