New issue
Advanced search Search tips

Issue 609687 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 610212



Sign in to add a comment

PROGRESS with -webkit-appearance:none should show fallback contnet

Project Member Reported by tkent@chromium.org, May 6 2016

Issue description

Similar to  Issue 51182  for METER, <progress style="-webkit-appearance:none">foo</progress> should show the content "foo".

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e63af3fae3962ddef32adde079fae2784085182

commit 9e63af3fae3962ddef32adde079fae2784085182
Author: tkent <tkent@chromium.org>
Date: Fri May 06 06:00:34 2016

Simplify HTMLProgressElement::didElementStateChange.

We can invalidate |:indeterminate| selector in parseAttribute().
Note that isDeterminate() is equivalent to fastHasAttribute(valueAttr).
This CL reduces dependency from HTMLProgressElement to LayoutProgress.

This CL has no behavior changes.

BUG=609687

Review-Url: https://codereview.chromium.org/1947423004
Cr-Commit-Position: refs/heads/master@{#392011}

[modify] https://crrev.com/9e63af3fae3962ddef32adde079fae2784085182/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12386b53694e014d2a5a0307dfc8efa6df19ece0

commit 12386b53694e014d2a5a0307dfc8efa6df19ece0
Author: tkent <tkent@chromium.org>
Date: Fri May 06 08:29:22 2016

Do not use LayoutProgress for a UA shadow element of a PROGRESS element.

The old behavior was the first child element of PROGRESS UA ShadowRoot used
LayoutProgress if the PROGRESS has -webkit-appearance:none.  However,
LayoutProgress does nothing if its associated element has no appearance.  So
the behavior made no sense.

This CL has no behavior changes.

BUG=609687

Review-Url: https://codereview.chromium.org/1958563002
Cr-Commit-Position: refs/heads/master@{#392023}

[modify] https://crrev.com/12386b53694e014d2a5a0307dfc8efa6df19ece0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/12386b53694e014d2a5a0307dfc8efa6df19ece0/third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt
[modify] https://crrev.com/12386b53694e014d2a5a0307dfc8efa6df19ece0/third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt
[modify] https://crrev.com/12386b53694e014d2a5a0307dfc8efa6df19ece0/third_party/WebKit/Source/core/css/html.css
[modify] https://crrev.com/12386b53694e014d2a5a0307dfc8efa6df19ece0/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp
[modify] https://crrev.com/12386b53694e014d2a5a0307dfc8efa6df19ece0/third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp
[modify] https://crrev.com/12386b53694e014d2a5a0307dfc8efa6df19ece0/third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.h
[modify] https://crrev.com/12386b53694e014d2a5a0307dfc8efa6df19ece0/third_party/WebKit/Source/core/layout/LayoutProgress.cpp
[modify] https://crrev.com/12386b53694e014d2a5a0307dfc8efa6df19ece0/third_party/WebKit/Source/core/layout/LayoutProgress.h

Project Member

Comment 3 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10be570d9538546a544cd0e12f41f41c6b0464d6

commit 10be570d9538546a544cd0e12f41f41c6b0464d6
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Fri May 06 09:37:05 2016

Auto-rebaseline for r392023

https://chromium.googlesource.com/chromium/src/+/12386b536

BUG=609687
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1958593002 .

Cr-Commit-Position: refs/heads/master@{#392027}

[modify] https://crrev.com/10be570d9538546a544cd0e12f41f41c6b0464d6/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/10be570d9538546a544cd0e12f41f41c6b0464d6/third_party/WebKit/LayoutTests/platform/android/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt
[add] https://crrev.com/10be570d9538546a544cd0e12f41f41c6b0464d6/third_party/WebKit/LayoutTests/platform/android/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt
[modify] https://crrev.com/10be570d9538546a544cd0e12f41f41c6b0464d6/third_party/WebKit/LayoutTests/platform/linux/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt
[modify] https://crrev.com/10be570d9538546a544cd0e12f41f41c6b0464d6/third_party/WebKit/LayoutTests/platform/linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt
[modify] https://crrev.com/10be570d9538546a544cd0e12f41f41c6b0464d6/third_party/WebKit/LayoutTests/platform/win/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt
[modify] https://crrev.com/10be570d9538546a544cd0e12f41f41c6b0464d6/third_party/WebKit/LayoutTests/platform/win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt

Project Member

Comment 4 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a21d40e8c4fddd9af8180dfa968794d6a9350eae

commit a21d40e8c4fddd9af8180dfa968794d6a9350eae
Author: tkent <tkent@chromium.org>
Date: Fri May 06 10:16:54 2016

Simplify PROGRESS shadow elements.

This CL removes the following elements, and use ProgressShadowElement instead.
 - ProgressInnerElement
 - ProgressBarElement
 - ProgressValueElement

The difference between ProgressInnerElement and ProgressShadowElement was only
openShadowRoot() check in layoutObjectIsNeeded().  The check is unnecessary now
because PROGRESS element can't have an open ShadowRoot.

ProgressBarElement and ProgressShadowElement were identical.

The difference between ProgressValueElement and ProgressShadowElement was only
setWidthPercentage(). The function is moved to HTMLProgressElement.

This CL has no behavior changes.

BUG=609687

Review-Url: https://codereview.chromium.org/1957593003
Cr-Commit-Position: refs/heads/master@{#392028}

[modify] https://crrev.com/a21d40e8c4fddd9af8180dfa968794d6a9350eae/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp
[modify] https://crrev.com/a21d40e8c4fddd9af8180dfa968794d6a9350eae/third_party/WebKit/Source/core/html/HTMLProgressElement.h
[modify] https://crrev.com/a21d40e8c4fddd9af8180dfa968794d6a9350eae/third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp
[modify] https://crrev.com/a21d40e8c4fddd9af8180dfa968794d6a9350eae/third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.h

Comment 5 by tkent@chromium.org, May 9 2016

Blockedon: 610212

Comment 6 by tkent@chromium.org, May 16 2016

Status: Assigned (was: Started)

Sign in to add a comment