New issue
Advanced search Search tips

Issue 609669 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Stop using custom style callbacks in AppearanceSwitchElement

Project Member Reported by tkent@chromium.org, May 6 2016

Issue description

A task tracking bug.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15

commit 19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15
Author: tkent <tkent@chromium.org>
Date: Mon May 16 01:07:12 2016

Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to METER element.

:-internal-shadow-host-has-appearance pseudo class matches to a shadow element if
  - it is in User-Agent ShadowRoot, and
  - its shadow host has -webkit-appearance value other than "none".
This class is available only in UA stylesheets.

Also, this CL adds PseudoBlinkInternalElement.  It's similar to
PseudoWebKitCustomElement.  Their differences are:
 - Pseudo ID of PseudoBlinkInternalElement starts with "-internal-".
 - ::-internal-* selectors are available only in UA stylesheets.

METER's fallback element uses PseudoBlinkInternalElement in order to avoid to
expose new vendor-specific elements.

This CL has no user-visible behavior changes.

BUG= 609669 

Review-Url: https://codereview.chromium.org/1958073002
Cr-Commit-Position: refs/heads/master@{#393779}

[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/LayoutTests/fast/dom/HTMLMeterElement/meter-styles.html
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/css/CSSSelector.cpp
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/css/CSSSelector.h
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/css/RuleFeature.cpp
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/css/RuleSet.cpp
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/css/html.css
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/html/HTMLMeterElement.cpp
[delete] https://crrev.com/b8e80fb5d475ac2b98fd87b25a111d3c4b0e28b0/third_party/WebKit/Source/core/html/shadow/AppearanceSwitchElement.cpp
[delete] https://crrev.com/b8e80fb5d475ac2b98fd87b25a111d3c4b0e28b0/third_party/WebKit/Source/core/html/shadow/AppearanceSwitchElement.h
[modify] https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

Comment 2 by tkent@chromium.org, May 16 2016

Status: Fixed (was: Started)

Sign in to add a comment