chromeos-setgoodkernel should not open and read every block device |
||
Issue descriptionAt the end of boot, when update-engine assesses it is valid, it calls chromeos-setgoodkernel to mark the boot as valid. chromeos-setgoodkernel call 'cgpt find' for finding the current boot device. [https://chromium.googlesource.com/chromiumos/platform2/+/master/installer/chromeos-setgoodkernel#36] This opens all block devices including the weird ones, like mmcblk0bootX and mmcblk0rpmb. We could be smarter, like doing $(rootdev -s) using partition number - 1.
,
May 6 2016
,
May 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/7427641541259f4adb27fc0dd74d3f3d35f66707 commit 7427641541259f4adb27fc0dd74d3f3d35f66707 Author: Gwendal Grignou <gwendal@chromium.org> Date: Fri May 06 04:05:10 2016 installer: Look for kernel partition in root device first. To prevent reading mmcblk0rmpb or mmcblk0rootX (these are rather expensive operation because we have to switch eMMC hardware partition), check first if the kernel partition the machine booted from is part of the root device. If not, try all the blocks are before. While there, add "${...}" around variable names. BUG=chromium:609661 TEST=Check with sh -x that the flow is correct. Tamper rootdev and check that alternate patch is taken. Change-Id: I7884441f5e06e7366bb698f5d8f7c5f31c5b1e68 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/342844 Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/7427641541259f4adb27fc0dd74d3f3d35f66707/installer/chromeos-setgoodkernel
,
Jan 11
You started fixing this bug over two years ago. Are you still working on it? |
||
►
Sign in to add a comment |
||
Comment 1 by marc.her...@gmail.com
, May 6 2016