New issue
Advanced search Search tips

Issue 609654 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

InsertListCommand hits DCHECK with TABLE

Project Member Reported by ClusterFuzz, May 5 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6524880241033216

Fuzzer: inferno_twister
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  CHECK failed: selection.isRange() in InsertListCommand.cpp
  blink::InsertListCommand::doApply
  blink::CompositeEditCommand::apply
  

Minimized Testcase (0.62 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96Bg6X-XcETVUoCaB1ECR_VmQSazbmDifesGaJ3k1ZsHgTMClu1Q4JJXoJPy819WTuEdj55mSuQh_zbbnkwtdhoj1nfmo2gn39yHl5k260yOk7wyLhX25GamKCWZXEZqNUvF5LNdO1zvNx6gr-9BsTNg5J9OQ

Filer: manoranjanr

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Tools>Test>FindIt>NoResult Blink
Labels: Te-Logged
Owner: koten...@yandex-team.ru
Status: Assigned (was: Available)
kotenkov@, could you please look into this change (https://chromium.googlesource.com/chromium/src/+/4021ae18b9410d496adc92077e00672253f3876d%5E%21/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp) if possible?

Thank you!
Components: -Blink Blink>Editing
Owner: yosin@chromium.org

Comment 5 by yosin@chromium.org, Jun 10 2016

Cc: -yosin@chromium.org
Components: Blink>Editing>Command
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
Summary: InsertListCommand hits DCHECK with TABLE (was: CHECK failed: selection.isRange() in InsertListCommand.cpp)
Lower to Pri-2, since real world usage of InsertOrderedList is low

DOM tree at DCHECK:

selection.showTreeForThis()
BODY	00000176985030A0
	DIV	0000017698503108 ID="div" (editable) (focused)
		TABLE	0000017698503170 (editable)
			TBODY	00000176985031F0 (editable)
				TR	0000017698503258 (editable)
SE					TD	00000176985032C0 (editable)
						SPAN	0000017698503328 ID="span" (editable)
							SCRIPT	0000017698503390 (editable)
								#text	0000017698503408 "\nsel = window.getSelection();\nsel.setBaseAndExtent(div, 78, span, span.childNodes.length);\ndocument.execCommand("InsertOrderedList");\n"
<void>

Project Member

Comment 6 by ClusterFuzz, Sep 22 2016

ClusterFuzz has detected this issue as fixed in range 392525:392540.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6524880241033216

Fuzzer: inferno_twister
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  selection.isRange() in InsertListCommand.cpp
  blink::InsertListCommand::doApply
  blink::CompositeEditCommand::apply
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_content_shell_drt&range=268656:269696
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_content_shell_drt&range=392525:392540

Minimized Testcase (0.20 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv96JSfk_87AHbIY_jB3UpNZFDC4gFMmGx4D5WHCvYl8ouN94pIxu-0Gft1yqabyXDSjPCTaXRtbJFvmGWczQ9Xf6lBglTSXFAYtb0I5IrpOv6gKoJpr6fFu4A0yVVWDDeqXf2qfQTrIxXBCnfTsAQypmk7RWHg?testcase_id=6524880241033216
<div contenteditable=true id=div><table><td><span id=span><script>
sel = window.getSelection();
sel.setBaseAndExtent(div, 78, span, span.childNodes.length);
document.execCommand("InsertOrderedList");
</script>


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Sep 22 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Components: -Tools>Test>FindIt>NoResult
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment