New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 609639 link

Starred by 1 user
Status: Verified
Owner:
█ ajnolley@chromium.org
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

[Windows Host] It2Me host crashes on connection in debug builds

Project Member Reported by joedow@chromium.org, May 5 2016 
While working on an different It2Me work item I noticed that every time I tried to connect the host would crash with an error: "Function marked as IO-only was called from a thread that disallows IO!...".

After some investigation I found that the It2Me host attempts to create the TouchInputInjector on its network thread (The Me2Me host creates this object on its UI thread). 

We should fix this so we can develop using debug builds for It2Me on Windows.
Project Member

Comment 1 by bugdroid1@chromium.org, May 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afc2dfda52924730d7d1b59eb4340fbeabdc8150

commit afc2dfda52924730d7d1b59eb4340fbeabdc8150
Author: joedow <joedow@chromium.org>
Date: Fri May 06 19:19:37 2016

Fixing an It2Me host crash on debug builds on Windows

While working on an different It2Me work item I noticed that every time I tried
to connect the host would crash with an error: "Function marked as IO-only was
called from a thread that disallows IO!...".

After some investigation I found that the It2Me host attempts to create the
TouchInputInjector (which loads a DLL) on its network thread causing the DCHECK
crash.  The Me2Me host creates this object on its UI thread which is also where
the injector is initialized so my fix is to move the creation of the
TouchInputInjector to the UI thread as well so we can guarantee it does not
occur on an invalid thread.

BUG= 609639 

Review-Url: https://codereview.chromium.org/1949113005
Cr-Commit-Position: refs/heads/master@{#392117}

[modify] https://crrev.com/afc2dfda52924730d7d1b59eb4340fbeabdc8150/remoting/host/input_injector_win.cc

Comment 2 by joedow@chromium.org, May 6 2016

Owner: ajnolley@chromium.org
Status: Fixed (was: Assigned)

Comment 3 by ajnolley@chromium.org, Jun 7 2016

Status: Verified (was: Fixed)
Verified fixed in  52.0.2743.24
►

Sign in to add a comment