New issue
Advanced search Search tips

Issue 609636 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

CQ failed to reject relocation_packer CL that broke Android build

Project Member Reported by r...@chromium.org, May 5 2016

Issue description

The analyze step on the android try job said it didn't need to build the change:
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/65803/steps/analyze/logs/stdio

CL that broke android builds:
https://codereview.chromium.org/1953863002/

Broken bot:
https://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/65870/

There are some gn arg differences between those two bots, and I noticed that these two test targets are present on the official bot but not the try bot: cronet_test_instrumentation_apk system_webview_apk
 
Cc: agrieve@chromium.org stip@chromium.org
Labels: -Pri-3 Pri-1
Owner: jbudorick@chromium.org
Status: Assigned (was: Unconfirmed)
I thought we were building 'all' on the android CQ bots. Did we stop that?
linux_android_rel_ng doesn't (and hasn't in a long time, if it ever did, due to cycle time). There are some bots that build more:
 - android_clang_dbg_recipe builds gn_all. It analyzed compilation away.
 - android_chromium_gn_compile_dbg builds all. It compiled successfull.

Android Builder doesn't build 'all' either, though. It builds the same targets that linux_android_rel_ng should.

My best guess at the moment is that this is happening because gn doesn't know that debug.h exists:

$ gn refs //out-gn/Release //third_party/android_platform/bionic/tools/relocation_packer/src/debug.h
The input matches no targets, configs, or files.

It seems like it should be part of //third_party/android_platform:android_lib_relocation_packer: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/android_platform/BUILD.gn&l=15

but it isn't: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/android_platform/relocation_packer.gyp&l=8
Status: Started (was: Assigned)
In the short term, I'm going to migrate the relevant bits of //third_party/android_platform/relocation_packer.gyp into //third_party/android_platform/BUILD.gn, remove the former, and then attempt to confirm that your change on reland will appropriately trigger the trybots.
After additional investigation:
 - #3 will only address part of the problem. relocation_packer/src/debug.h is only used in a target built with the host toolchain, so tools/mb/mb.py analyze, which calls gn refs ... without --all-toolchains , won't pick it up even after the change.
 - android_chromium_gn_compile_dbg is configured to do a component build. relocation packing is disabled for component builds*, so even though it built all, it didn't build android_relocation_packer.

* chrome_public_apk_use_relocation_packer is true only if chromium_linker_supported is true: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/chrome_public_apk_tmpl.gni&l=17
  which is only true for non-component builds: https://code.google.com/p/chromium/codesearch#chromium/src/base/android/linker/config.gni&l=11

I'm still going to do what I suggested in #3 (though might leave relocation_packer.gyp for the time being), but that won't be sufficient to fix this.
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cdc1b957aae6d011b05bacd788af0c056d9fdf6

commit 1cdc1b957aae6d011b05bacd788af0c056d9fdf6
Author: jbudorick <jbudorick@chromium.org>
Date: Mon May 09 16:04:40 2016

[Android] Move relocation_packer sources specification into gn.

BUG= 609636 

Review-Url: https://codereview.chromium.org/1961433002
Cr-Commit-Position: refs/heads/master@{#392327}

[modify] https://crrev.com/1cdc1b957aae6d011b05bacd788af0c056d9fdf6/third_party/android_platform/BUILD.gn

Components: -Build Infra>Client>Android

Comment 7 by stip@chromium.org, Jan 5 2017

John, is this still an issue?
Cc: jbudorick@chromium.org
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Started)
Yes. We'd need to do a full static build on a trybot. mb.py analyze now uses gn analyze, not gn refs, so I'm not sure if that part's still a problem.

Either way, I don't think this is a P1 any more, and I'm definitely not going to be able to work on it in the near- to medium-term.

Comment 9 by stip@chromium.org, Feb 10 2017

Cc: -stip@chromium.org
Components: Infra>Client>Chrome
Infra>Client>Android -> Infra>Client>Chrome + OS=Android
Components: -Infra>Client>Android
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 4

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Archived (was: Untriaged)

Sign in to add a comment