New issue
Advanced search Search tips

Issue 609625 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 595653

Blocking:
issue 433082
issue 621681



Sign in to add a comment

GN not allowing optimization with AFDO on ChromeOS

Project Member Reported by llozano@chromium.org, May 5 2016

Issue description

While doing experiments with GN for ChromeOS ebuild workflow, I noticed the  builds are not using the -fauto-profile=<profile> option.

This is used to optimize chrome with AFDO (profile guided optimizations) and brings large performance improvements to Chrome. 


 
Cc: dpranke@chromium.org hashimoto@chromium.org
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
I believe that we have specifically not tried converting AFDO yet in the ebuild.

Unfortunately there is a -lot- of custom code in the ebuild for AFDO.

For GYP, it all ends up being passed as CXXFLAGS.. 
And all the custom code in the ebuild is independent of GYP/GN.. 
Blockedon: -595363 595653
Blocking: 433082
Owner: llozano@chromium.org
Will this be addressed with the CXXFLAGS related fixes? If something more needs to be done, feel free to assign this back to me.

Blocking: 621681
Labels: -Pri-1 M-53 Pri-2
@llozano - is this done? If not, does this need to be done before we ship?
Status: Verified (was: Assigned)
I think this was fixed by the CXXFLAGS change. 
I will close this.

Sign in to add a comment