New issue
Advanced search Search tips

Issue 609620 link

Starred by 1 user
Status: Verified
Owner:
rtoy@chromium.org
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Typo in HardwareBuffersize UMA histogram reporting

Project Member Reported by rtoy@chromium.org, May 5 2016 
There's a typo in the UMA histogram reporting for the hardware buffer size for WebAudio.

The code says "WebAudio.AudioDestination.HardwareBuffersize", but the histogram name is actually "WebAudio.AudioDestination.HardwareBufferSize"

(Note size vs Size.)
Project Member

Comment 1 by bugdroid1@chromium.org, May 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2131caa7cc48c07ac4d5920bfd22c04bd35f670c

commit 2131caa7cc48c07ac4d5920bfd22c04bd35f670c
Author: rtoy <rtoy@chromium.org>
Date: Fri May 06 02:34:35 2016

Fix typo in UMA histogram name.

The histogram name is WebAudio.AudioDestination.HardwareBufferSize,
but the code used WebAudio.AudioDestination.HardwareBuffersize ("Size
vs "size").

BUG= 609620 
TEST=manually verified that HardwareBufferSize histogram changes in chrome://histogram

Review-Url: https://codereview.chromium.org/1954913002
Cr-Commit-Position: refs/heads/master@{#391989}

[modify] https://crrev.com/2131caa7cc48c07ac4d5920bfd22c04bd35f670c/third_party/WebKit/Source/platform/audio/AudioDestination.cpp

Comment 2 by rtoy@chromium.org, May 10 2016

Status: Verified (was: Started)
I can see the new stats now.  Interesting results are already showing up.
►

Sign in to add a comment