New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 609614 link

Starred by 1 user
Status: Verified
Owner: ----
Closed: Jun 2016
Cc:
█ stevenh@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 433082



Sign in to add a comment

GN fails for ChromeOS when using 'chrome_internal'

Project Member Reported by llozano@chromium.org, May 5 2016 

when doing 

 USE='gn build_tests chrome_internal afdo_use' emerge-x86-alex chromeos-chrome

I get the following error:

gn.py: Could not find gn executable at: /var/cache/chromeos-cache/distfiles/target/chrome-src-internal/buildtools/linux64/gn

This error does not happen if I dont use chrome_internal.

Comment 1 by dpranke@chromium.org, May 6 2016

Cc: steve...@chromium.org
I'm not quite sure what's going on, but I strongly recommend we modify the ebuild scripts to invoke the correct GN binary directly (or via a wrapper that lives in the chromium checkout) rather than invoking things through the gn.py that lives in depot_tools, which is more provided for developer convenience.

That said, is it possible your chrome_internal flag is causing the build to not pick up GN the way we pick it normally

Comment 2 by dpranke@chromium.org, May 6 2016

Blocking: 433082

Comment 3 by dpranke@chromium.org, Jun 20 2016

Status: Fixed (was: Untriaged)
I believe this has been fixed ...

Comment 4 by llozano@chromium.org, Jun 20 2016

Status: Verified (was: Fixed)
yes, as far as I can tell. Not sure how it got fixed.

Comment 5 by dpranke@chromium.org, Jun 20 2016 

We switched to invoking the binary directly.

Comment 6 by steve...@chromium.org, Jun 21 2016 

Something similar was reported in issue 588794

I'm not sure what exactly we changed here, but somehow this is still broken on the builders. Let's track the current failure on that (still open) issue.
►

Sign in to add a comment