New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609606 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 626364
Owner: ----
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 626364



Sign in to add a comment

What's the story with TBR for Gerrit?

Project Member Reported by tandrii@chromium.org, May 5 2016

Issue description

in Rietveld world, it's often useful to upload a change with TBR and then land it anyways. What should be the scheme for Gerrit?
 
If someone has commit access they can just set the bit themselves. I must be missing something about the flow or how the tools integrate with it. Could you be more specific with example workflows?
so, first git cl --tbr doeesn't work for Gerrit yet. For Rietveld, it's quite simple:
  add TBR=xxx@chromium.org to description OR --tbr xxx@chromium.org as cmd
  and then juts hit CQ or git cl land.

for Gerrit, first you add normal reviewers. Then you must edit TBR= inside CL message. Then after upload, one has to go to web UI and rather un-intuitive (for Rietveld convert) step LGTM-ing oneself. And then trigger CQ or run git cl land or git cl set-commit.

IMO, this has to be smoother.
Labels: Pri-2
Labels: Type-Bug
Labels: Proj-Gerrit-Migration
Status: Available (was: Untriaged)
Blockedon: 626364
 issue 626364  implements obeying TBR= in description, and hence --tbr-owners option of git cl, which makes life smooth, IMO.

also, FTR, git cl --tbr doesn't exist.
Blockedon: -626364
Mergedinto: 626364
Status: Duplicate (was: Available)
Hm, I wonder if anything has to be done here at all beyond 626364. I think not. Marking as dup.
Blockedon: 626364

Sign in to add a comment