New issue
Advanced search Search tips

Issue 609580 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: do not require huge min icon size while emulating add to home screen.

Project Member Reported by pfeldman@chromium.org, May 5 2016

Issue description

Otherwise, Mac Retina wants 256.
 
Project Member

Comment 2 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23ac1ebc5f3a65cc260e6d4e83015d04ff7a3441

commit 23ac1ebc5f3a65cc260e6d4e83015d04ff7a3441
Author: sky <sky@chromium.org>
Date: Fri May 06 23:39:07 2016

Revert of DevTools: account for the display scale factor while validating manifest under emulation. (patchset #5 id:80001 of https://codereview.chromium.org/1950133009/ )

Reason for revert:
For reasons outlined in latest comment.

Original issue's description:
> DevTools: account for the display scale factor while validating manifest under emulation.
>
> BUG= 609580 
> TBR=sky
>
> Committed: https://crrev.com/aeb778c817766d5c3b17097556218b0bafdbd1d4
> Cr-Commit-Position: refs/heads/master@{#392171}

TBR=dominickn@chromium.org,dfalcantara@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 609580 

Review-Url: https://codereview.chromium.org/1955183002
Cr-Commit-Position: refs/heads/master@{#392204}

[delete] https://crrev.com/6e156cf96a391ee35e402da76455969a1b11f169/chrome/browser/banners/app_banner_manager_emulation.cc
[delete] https://crrev.com/6e156cf96a391ee35e402da76455969a1b11f169/chrome/browser/banners/app_banner_manager_emulation.h
[modify] https://crrev.com/23ac1ebc5f3a65cc260e6d4e83015d04ff7a3441/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/23ac1ebc5f3a65cc260e6d4e83015d04ff7a3441/chrome/browser/ui/browser.cc
[modify] https://crrev.com/23ac1ebc5f3a65cc260e6d4e83015d04ff7a3441/chrome/browser/ui/browser.h
[modify] https://crrev.com/23ac1ebc5f3a65cc260e6d4e83015d04ff7a3441/chrome/chrome_browser.gypi

Status: Fixed (was: Assigned)

Sign in to add a comment