New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 609578 link

Starred by 2 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

ManagePasswordsDecoration unit tests break under Material Design

Project Member Reported by shrike@chromium.org, May 5 2016 
The issue is comparing old PNG icons to the new vector images, and a NULL pointer access in ManagePasswordsDecoration::UpdateUIState().
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ef553f7f2825bdeb386996fa105193255b64271

commit 8ef553f7f2825bdeb386996fa105193255b64271
Author: shrike <shrike@chromium.org>
Date: Thu May 05 22:39:15 2016

[Mac][Material Design] Fix ManagePasswordsDecoration unit tests

Under Material Design the ManagePasswordsDecoration unit tests broke
because of comparing the old PNG icons to the new vector icons, and
because of a NULL pointer dereference.

R=avi@chromium.org
BUG= 609578 

Review-Url: https://codereview.chromium.org/1959473002
Cr-Commit-Position: refs/heads/master@{#391930}

[modify] https://crrev.com/8ef553f7f2825bdeb386996fa105193255b64271/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm
[modify] https://crrev.com/8ef553f7f2825bdeb386996fa105193255b64271/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm

Comment 2 by shrike@chromium.org, May 5 2016

Status: Fixed (was: Started)
►

Sign in to add a comment