New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 609570 link

Starred by 2 users
Status: Fixed
Owner:
█ chili@chromium.org
Last visit 22 days ago
Closed: Jul 2016
Cc:
dewittj@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Chrome should have a chrome://offline-internals to assist in debugging offline pages

Project Member Reported by dewittj@chromium.org, May 5 2016 
Many complex features have internals pages that can be used to display data structures that Chrome is using to support those features.  Example:

chrome://gcm-internals
chrome://sync-inte

We would like a chrome://offline-pages-internals that can show what's in our database and the various metadata about each page.

Comment 1 by chili@chromium.org, May 9 2016 

What information about each page would you like to show?

Comment 2 by dewittj@chromium.org, May 9 2016 

#1: This will probably need a doc that's shared with the rest of the team.  At a very least, it'd be nice to be able to see stats broken down by feature, and to browse the entire offline DB.  Also to navigate to each offline page stored in the DB.

Comment 3 by chili@chromium.org, May 18 2016

Status: Started (was: Assigned)
Doc at go/paquete-internals
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9e16a70339082317d07db9f4165e10257723a28

commit b9e16a70339082317d07db9f4165e10257723a28
Author: chili <chili@chromium.org>
Date: Tue Jun 07 21:47:07 2016

[Offline pages] Create offline internals page for android

BUG= 609570 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2003883002
Cr-Commit-Position: refs/heads/master@{#398394}

[modify] https://crrev.com/b9e16a70339082317d07db9f4165e10257723a28/chrome/browser/browser_resources.grd
[add] https://crrev.com/b9e16a70339082317d07db9f4165e10257723a28/chrome/browser/resources/offline_pages/offline_internals.css
[add] https://crrev.com/b9e16a70339082317d07db9f4165e10257723a28/chrome/browser/resources/offline_pages/offline_internals.html
[add] https://crrev.com/b9e16a70339082317d07db9f4165e10257723a28/chrome/browser/resources/offline_pages/offline_internals.js
[modify] https://crrev.com/b9e16a70339082317d07db9f4165e10257723a28/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[add] https://crrev.com/b9e16a70339082317d07db9f4165e10257723a28/chrome/browser/ui/webui/offline_internals_ui.cc
[add] https://crrev.com/b9e16a70339082317d07db9f4165e10257723a28/chrome/browser/ui/webui/offline_internals_ui.h
[modify] https://crrev.com/b9e16a70339082317d07db9f4165e10257723a28/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/b9e16a70339082317d07db9f4165e10257723a28/chrome/common/url_constants.cc
[modify] https://crrev.com/b9e16a70339082317d07db9f4165e10257723a28/chrome/common/url_constants.h
[modify] https://crrev.com/b9e16a70339082317d07db9f4165e10257723a28/tools/metrics/histograms/histograms.xml
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27d6f0a481a7f73b7dd60f894000c8d22f735332

commit 27d6f0a481a7f73b7dd60f894000c8d22f735332
Author: chili <chili@chromium.org>
Date: Wed Jun 15 01:57:02 2016

[Offline Pages] Link the internals page with the offline model and request
coordinators

- Adds functionality to 'dump' all content into a csv file for download.
- Adds adds the resource files to closure

BUG= 609570 
DIFF_BASE=2003883002
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2038963002
Cr-Commit-Position: refs/heads/master@{#399818}

[add] https://crrev.com/27d6f0a481a7f73b7dd60f894000c8d22f735332/chrome/browser/resources/offline_pages/compiled_resources2.gyp
[modify] https://crrev.com/27d6f0a481a7f73b7dd60f894000c8d22f735332/chrome/browser/resources/offline_pages/offline_internals.html
[modify] https://crrev.com/27d6f0a481a7f73b7dd60f894000c8d22f735332/chrome/browser/resources/offline_pages/offline_internals.js
[modify] https://crrev.com/27d6f0a481a7f73b7dd60f894000c8d22f735332/chrome/browser/ui/webui/offline_internals_ui.cc
[modify] https://crrev.com/27d6f0a481a7f73b7dd60f894000c8d22f735332/third_party/closure_compiler/compiled_resources2.gyp
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70608500dc1a8019024023710ed4267a90069e43

commit 70608500dc1a8019024023710ed4267a90069e43
Author: chili <chili@chromium.org>
Date: Mon Jun 27 12:46:20 2016

[Offline Pages] Create a event/activity logger

This is used by both the offline page model and the request coordinator.

BUG= 609570 

Review-Url: https://codereview.chromium.org/2089413002
Cr-Commit-Position: refs/heads/master@{#402156}

[modify] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/components_tests.gyp
[modify] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages.gypi
[modify] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/BUILD.gn
[modify] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/background/BUILD.gn
[modify] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/background/request_coordinator.h
[add] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/background/request_coordinator_event_logger.cc
[add] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/background/request_coordinator_event_logger.h
[add] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/background/request_coordinator_event_logger_unittest.cc
[add] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/offline_event_logger.cc
[add] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/offline_event_logger.h
[modify] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/offline_page_model.h
[add] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/offline_page_model_event_logger.cc
[add] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/offline_page_model_event_logger.h
[add] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/offline_page_model_event_logger_unittest.cc
[modify] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/offline_page_model_impl.h
[modify] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/stub_offline_page_model.cc
[modify] https://crrev.com/70608500dc1a8019024023710ed4267a90069e43/components/offline_pages/stub_offline_page_model.h

Comment 9 by chili@chromium.org, Jul 20 2016

Status: Fixed (was: Started)
All the base functionality has been completed.  FAQs at go/paquete-internals-faq for how to expand the page.
►

Sign in to add a comment