New issue
Advanced search Search tips

Issue 609566 link

Starred by 1 user
Status: Fixed
Owner:
dewittj@chromium.org
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Offline Pages should not be automatically saved if Cache-Control: no-store is present.

Project Member Reported by dewittj@chromium.org, May 5 2016 
Today we do some automatic offlining of content, but we should obey the site owner's intent since the user didn't explicitly ask us to download the page.

Example:
Bank site could be marked no-store so that sensitive account details aren't cached on disk.

TEST:
tripadvisor.com is marked no-store, so it's easily usable as a test page.

Comment 1 by dewittj@chromium.org, May 5 2016

Labels: -Pri-3 OS-Android Pri-1
Owner: dewittj@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009

commit 6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009
Author: dewittj <dewittj@chromium.org>
Date: Tue May 17 01:48:47 2016

Introduces a new MHTML generation parameter specifying different behvaior for cache-control headers.

BUG= 609566 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1947263004
Cr-Commit-Position: refs/heads/master@{#394013}

[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/android_webview/native/aw_contents.cc
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/chrome/browser/extensions/api/page_capture/page_capture_api.cc
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/browser/download/mhtml_generation_browsertest.cc
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/browser/download/mhtml_generation_manager.cc
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/browser/download/mhtml_generation_manager.h
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/browser/download/save_package.cc
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/child/assert_matching_enums.cc
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/common/frame_messages.h
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/content_common.gypi
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/public/browser/web_contents.h
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/public/common/common_param_traits_macros.h
[add] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/public/common/mhtml_generation_params.cc
[add] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/public/common/mhtml_generation_params.h
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/renderer/render_frame_impl.cc
[add] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/test/data/nostore.html
[add] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/content/test/data/nostore.html.mock-http-headers
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/third_party/WebKit/Source/web/WebFrameSerializer.cpp
[modify] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/third_party/WebKit/public/web/WebFrameSerializer.h
[add] https://crrev.com/6dc5747a6c25cc8ea1d034503e9a33bcf5dd0009/third_party/WebKit/public/web/WebFrameSerializerCacheControlPolicy.h
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8f8297de77fc3688e05b459f0cb6448209ad2ea

commit a8f8297de77fc3688e05b459f0cb6448209ad2ea
Author: dewittj <dewittj@chromium.org>
Date: Mon May 23 19:04:38 2016

Adds a feature to MHTML serialization that omits subframes and subresources marked no-store.

Also integrates this new feature with the offline page archiver.  Note that because CSS is not considered a resource
when serializing, CSS will be covered separately.

BUG= 609566 

Review-Url: https://codereview.chromium.org/1977303003
Cr-Commit-Position: refs/heads/master@{#395380}

[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/content/browser/DEPS
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/content/browser/download/mhtml_generation_browsertest.cc
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/content/child/assert_matching_enums.cc
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/content/common/DEPS
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/content/common/frame_messages.h
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/content/public/common/mhtml_generation_params.h
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/content/renderer/render_frame_impl.cc
[add] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/content/test/data/nostore.jpg
[add] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/content/test/data/nostore.jpg.mock-http-headers
[add] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/content/test/data/page_with_nostore_iframe.html
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/third_party/WebKit/Source/core/fetch/Resource.h
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/third_party/WebKit/Source/core/frame/FrameSerializer.cpp
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/third_party/WebKit/Source/core/frame/FrameSerializer.h
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/third_party/WebKit/Source/web/WebFrameSerializer.cpp
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/third_party/WebKit/public/web/WebFrameSerializer.h
[modify] https://crrev.com/a8f8297de77fc3688e05b459f0cb6448209ad2ea/third_party/WebKit/public/web/WebFrameSerializerCacheControlPolicy.h

Comment 4 by dewittj@chromium.org, Jun 15 2016

Components: UI>Browser>Offline
Status: Fixed (was: Started)
This is fixed to the degree that it will be fixed.
►

Sign in to add a comment