New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 609555 link

Starred by 1 user
Status: Verified
Owner:
█ markdittmer@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
█ fsam...@chromium.org
sadrul@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 616101


Sign in to add a comment

views::NativeWidgetMus should directly control its mus::Window

Project Member Reported by markdittmer@chromium.org, May 5 2016 
Right now information flows:

views::NativeWidgetMus -> views::WindowTreeHostMus -> views::PlatformWindowMus -> mus::Window

There is also a similar flow that bypasses views::PlatformWindowMus. We wish to simplify this to:

views::NativeWidgetMus -> mus::Window

views::NativeWidgetMus will still need to notify its aura::WindowTreeHost of updates because other components querying the window tree must get accurate information about mus widgets. Said WindowTreeHost will now be instantiated with a stub PlatformWindow because it won't need to forward information to mus anymore.

Comment 1 by sadrul@chromium.org, May 5 2016

Cc: sky@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1462909717a364b71c6291e742b2fc763b69b849

commit 1462909717a364b71c6291e742b2fc763b69b849
Author: markdittmer <markdittmer@chromium.org>
Date: Tue May 10 15:31:51 2016

Move Show and Hide impls from PlatformWindowMus to NativeWidgetMus

R=sadrul@chromium.org
BUG= 609555 

Review-Url: https://codereview.chromium.org/1962043002
Cr-Commit-Position: refs/heads/master@{#392615}

[modify] https://crrev.com/1462909717a364b71c6291e742b2fc763b69b849/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/1462909717a364b71c6291e742b2fc763b69b849/ui/views/mus/platform_window_mus.cc
Project Member

Comment 6 by bugdroid1@chromium.org, May 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13982c3193706f64bdbd2bb449f9aa94905a2920

commit 13982c3193706f64bdbd2bb449f9aa94905a2920
Author: markdittmer <markdittmer@chromium.org>
Date: Fri May 13 22:53:59 2016

Move remaining mus::WindowObserver lifecycle callbacks from PlatformWindowMus to NativeWidgetMus::MusWindowObserver

R=sadrul@chromium.org
BUG= 609555 

Review-Url: https://codereview.chromium.org/1975873002
Cr-Commit-Position: refs/heads/master@{#393667}

[modify] https://crrev.com/13982c3193706f64bdbd2bb449f9aa94905a2920/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/13982c3193706f64bdbd2bb449f9aa94905a2920/ui/views/mus/platform_window_mus.cc
[modify] https://crrev.com/13982c3193706f64bdbd2bb449f9aa94905a2920/ui/views/mus/platform_window_mus.h
Project Member

Comment 8 by bugdroid1@chromium.org, May 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b693cb69c1731ac3e4fa0851e64fd10fa820a1c

commit 6b693cb69c1731ac3e4fa0851e64fd10fa820a1c
Author: sadrul <sadrul@chromium.org>
Date: Thu May 19 20:59:45 2016

views/mus: Fix input event handling.

Input event handling moved from PlatformWindowMus to NativeWidgetMus
in https://crrev.com/394564, but NativeWidgetMus wasn't installing
itself as the input-event handler for the mus::Window.

BUG= 609555 

Review-Url: https://codereview.chromium.org/1990333002
Cr-Commit-Position: refs/heads/master@{#394860}

[modify] https://crrev.com/6b693cb69c1731ac3e4fa0851e64fd10fa820a1c/ui/views/mus/native_widget_mus.cc
Project Member

Comment 10 by bugdroid1@chromium.org, May 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b2114f0e297428fbe15ef169d05f9bbf9749a8e

commit 2b2114f0e297428fbe15ef169d05f9bbf9749a8e
Author: markdittmer <markdittmer@chromium.org>
Date: Tue May 24 21:12:56 2016

Finish eliminating PlatformWindowMus

R=sadrul@chromium.org
BUG= 609555 

Review-Url: https://codereview.chromium.org/1999083002
Cr-Commit-Position: refs/heads/master@{#395694}

[modify] https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e/ash/host/ash_window_tree_host_unified.cc
[modify] https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e/ash/mus/sysui_application.cc
[modify] https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e/blimp/engine/app/ui/blimp_window_tree_host.cc
[modify] https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e/ui/platform_window/stub/stub_window.cc
[modify] https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e/ui/platform_window/stub/stub_window.h
[modify] https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e/ui/views/mus/BUILD.gn
[modify] https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e/ui/views/mus/native_widget_mus_unittest.cc
[delete] https://crrev.com/812bb854380007efc5852037af26632797053e90/ui/views/mus/platform_window_mus.cc
[delete] https://crrev.com/812bb854380007efc5852037af26632797053e90/ui/views/mus/platform_window_mus.h
[modify] https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e/ui/views/mus/window_tree_host_mus.cc
[modify] https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e/ui/views/mus/window_tree_host_mus.h
Project Member

Comment 11 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f

commit 70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f
Author: sadrul <sadrul@chromium.org>
Date: Wed May 25 02:13:11 2016

Revert of Finish eliminating PlatformWindowMus (patchset #7 id:120001 of https://codereview.chromium.org/1999083002/ )

Reason for revert:
This breaks window-frames in mash

Original issue's description:
> Finish eliminating PlatformWindowMus
>
> R=sadrul@chromium.org
> BUG= 609555 
>
> Committed: https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e
> Cr-Commit-Position: refs/heads/master@{#395694}

TBR=nyquist@chromium.org,sky@chromium.org,markdittmer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 609555 

Review-Url: https://codereview.chromium.org/2013713002
Cr-Commit-Position: refs/heads/master@{#395779}

[modify] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/ash/host/ash_window_tree_host_unified.cc
[modify] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/ash/mus/sysui_application.cc
[modify] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/blimp/engine/app/ui/blimp_window_tree_host.cc
[modify] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/ui/platform_window/stub/stub_window.cc
[modify] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/ui/platform_window/stub/stub_window.h
[modify] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/ui/views/mus/BUILD.gn
[modify] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/ui/views/mus/native_widget_mus_unittest.cc
[add] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/ui/views/mus/platform_window_mus.cc
[add] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/ui/views/mus/platform_window_mus.h
[modify] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/ui/views/mus/window_tree_host_mus.cc
[modify] https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f/ui/views/mus/window_tree_host_mus.h

Comment 13 by markdittmer@chromium.org, May 31 2016

Blockedon: 616101

Comment 14 by rjkroege@chromium.org, Aug 8 2016 

markdittmer: can you finish or pass on to someone else? sadrul@ maybe?

Comment 15 by varkha@chromium.org, Aug 8 2016 

markdittmer@, are you still working on this or should we look for an owner?

Comment 16 by sadrul@chromium.org, Aug 8 2016

Status: Fixed (was: Started)
I think this is done. Closing as fixed.

Comment 17 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 18 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 19 by dhadd...@chromium.org, Oct 19 2016

Status: Verified (was: Fixed)

Comment 20 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService
►

Sign in to add a comment