New issue
Advanced search Search tips

Issue 609532 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 430155



Sign in to add a comment

compositor-worker: Ensure that v8 GC works on the compositor thread

Project Member Reported by vollick@chromium.org, May 5 2016

Issue description

Since we may have no idle windows, we need to make confirm that v8 won't continually re-post idle gc work and starve other work in the meantime.

 
(Stating the obvious that the preferred fix would be to have idle periods on the compositor worker thread :)

Comment 2 by flackr@chromium.org, Jan 24 2017

Labels: -Hotlist-Threaded-Rendering Hotlist-ThreadedRendering
Owner: majidvp@chromium.org
Assigning to Majid to own. This may be a no-op which already works.
I feel that this may no longer be an issue once we have a dedicated thread for animation worklets. 

In particular on a dedicated thread, it seem reasonable for gc work to starve the web page animation tasks if we are under memory pressure and have no idle period. Do we have a different strategy on main thread?
So animation worklets will no longer run on the compositor thread?

Idle GC on the main thread is meant to reduce the probability of a blocking GC. It feels like a similar strategy would work for animation worklets.
> So animation worklets will no longer run on the compositor thread?
Correct. We have not made the migration yet but it is the plan ( issue 731727 ).


Status: WontFix (was: Available)
Closing as the plan of record is to move AW to dedicated thread and it is currently in progress here: https://chromium-review.googlesource.com/c/chromium/src/+/630857


Sign in to add a comment