Remove url scheme from the chooser bubble title text |
||
Issue descriptionOS: Linux, ChromeOS, Windows, Mac The title of the chooser bubble needs to show: "example.com wants to connect to:" instead of: "https://example.com wants to connect to:"
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e20b35e488e98992cc193f4ac239425d9cf23c5 commit 9e20b35e488e98992cc193f4ac239425d9cf23c5 Author: juncai <juncai@chromium.org> Date: Fri May 13 18:08:33 2016 Update ChooserBubbleUiController to use FormatOriginForSecurityDisplay Since FormatOriginForSecurityDisplay() was added to take url::Origin as the parameter, ChooserBubbleUiController can use it to display the origin on the chooser bubble title. BUG= 609521 , 529950 Review-Url: https://codereview.chromium.org/1976863002 Cr-Commit-Position: refs/heads/master@{#393580} [modify] https://crrev.com/9e20b35e488e98992cc193f4ac239425d9cf23c5/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/295014fabd464fad9af3beca50ad31842fe473fd commit 295014fabd464fad9af3beca50ad31842fe473fd Author: juncai <juncai@chromium.org> Date: Wed May 18 21:45:06 2016 Remove url scheme from the chooser bubble title To be the same with the title of other bubbles such as notification, geo location, etc., the title of the chooser bubble needs to remove the url scheme. For example, it needs to show: "example.com wants to connect to:" instead of: "https://example.com wants to connect to:" BUG= 609521 , 529950 Review-Url: https://codereview.chromium.org/1948313003 Cr-Commit-Position: refs/heads/master@{#394559} [modify] https://crrev.com/295014fabd464fad9af3beca50ad31842fe473fd/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc
,
May 20 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 5 2016