New issue
Advanced search Search tips

Issue 609521 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Remove url scheme from the chooser bubble title text

Project Member Reported by juncai@chromium.org, May 5 2016

Issue description

OS: Linux, ChromeOS, Windows, Mac

The title of the chooser bubble needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9895021bcaad569bc377b6f53b5adcd2f1a34779

commit 9895021bcaad569bc377b6f53b5adcd2f1a34779
Author: juncai <juncai@chromium.org>
Date: Thu May 05 18:16:38 2016

Remove url scheme from the chooser bubble title on Mac

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to remove the url scheme. For example, it
needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG= 609521 ,  529950 

Review-Url: https://codereview.chromium.org/1950333002
Cr-Commit-Position: refs/heads/master@{#391845}

[modify] https://crrev.com/9895021bcaad569bc377b6f53b5adcd2f1a34779/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

Project Member

Comment 2 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e20b35e488e98992cc193f4ac239425d9cf23c5

commit 9e20b35e488e98992cc193f4ac239425d9cf23c5
Author: juncai <juncai@chromium.org>
Date: Fri May 13 18:08:33 2016

Update ChooserBubbleUiController to use FormatOriginForSecurityDisplay

Since FormatOriginForSecurityDisplay() was added to take url::Origin
as the parameter, ChooserBubbleUiController can use it to display
the origin on the chooser bubble title.

BUG= 609521 ,  529950 

Review-Url: https://codereview.chromium.org/1976863002
Cr-Commit-Position: refs/heads/master@{#393580}

[modify] https://crrev.com/9e20b35e488e98992cc193f4ac239425d9cf23c5/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/295014fabd464fad9af3beca50ad31842fe473fd

commit 295014fabd464fad9af3beca50ad31842fe473fd
Author: juncai <juncai@chromium.org>
Date: Wed May 18 21:45:06 2016

Remove url scheme from the chooser bubble title

To be the same with the title of other bubbles such as
notification, geo location, etc., the title of the chooser
bubble needs to remove the url scheme. For example, it
needs to show:
"example.com wants to connect to:"
instead of:
"https://example.com wants to connect to:"

BUG= 609521 ,  529950 

Review-Url: https://codereview.chromium.org/1948313003
Cr-Commit-Position: refs/heads/master@{#394559}

[modify] https://crrev.com/295014fabd464fad9af3beca50ad31842fe473fd/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc

Comment 4 by juncai@chromium.org, May 20 2016

Status: Fixed (was: Started)

Sign in to add a comment