New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609503 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 619084



Sign in to add a comment

Implement an audio focus manager on non-Mobile Chrome

Project Member Reported by mlamouri@chromium.org, May 5 2016

Issue description

The media session delegate for desktop is very basic and doesn't really handle audio focus. Ideally, it should talk to an audio focus manager as the Android media session delegate does except that Chrome would implement it instead of the system.

Requirements for the audio focus manager would be:
- lazy initialised singleton (one per browser process);
- it handles a stack of audio focus requests so it can give back audio focus to WebContents that lost it;
- it keep tracks of WebContents' death;
- it handles at least two types of audio focus gain (content and transient).
 
Labels: -M-52 M-53
Blocking: 619084
Labels: -M-53 M-54
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce42802dbc1e900b9d0689508b2f6284ee617a55

commit ce42802dbc1e900b9d0689508b2f6284ee617a55
Author: mlamouri <mlamouri@chromium.org>
Date: Thu Jul 21 14:21:55 2016

Implement Audio Focus Manager for desktop.

This CL implements a real Audio Focus Manager internal to Chrome.
The intent is to use it on Chrome desktop, when there is no system
audio focus manager.

The Audio Focus Manager handles ducking and audio focus gain. At
the moment, the rules are that only one entry can have audio focus
and any transient will duck the audio focus entry.

BUG= 609503 

Review-Url: https://codereview.chromium.org/1971443002
Cr-Commit-Position: refs/heads/master@{#406843}

[add] https://crrev.com/ce42802dbc1e900b9d0689508b2f6284ee617a55/content/browser/media/session/audio_focus_manager.cc
[add] https://crrev.com/ce42802dbc1e900b9d0689508b2f6284ee617a55/content/browser/media/session/audio_focus_manager.h
[add] https://crrev.com/ce42802dbc1e900b9d0689508b2f6284ee617a55/content/browser/media/session/audio_focus_manager_unittest.cc
[modify] https://crrev.com/ce42802dbc1e900b9d0689508b2f6284ee617a55/content/browser/media/session/media_session.h
[modify] https://crrev.com/ce42802dbc1e900b9d0689508b2f6284ee617a55/content/browser/media/session/media_session_delegate_default.cc
[modify] https://crrev.com/ce42802dbc1e900b9d0689508b2f6284ee617a55/content/content_browser.gypi
[modify] https://crrev.com/ce42802dbc1e900b9d0689508b2f6284ee617a55/content/content_tests.gypi

Status: Fixed (was: Started)

Sign in to add a comment