New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609502 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 425625
issue 619799



Sign in to add a comment

Open Tabs in MD History should have its own URL

Project Member Reported by calamity@chromium.org, May 5 2016

Issue description

From  Issue 608973 :
'"Open tabs" should really have its own URL (like all of the dialogs in chrome://settings) so that a user can bookmark or navigate directly to that tab. Such as chrome://history/devices.'
 
Suggested URL from  issue 608973  is chrome://history/syncedtabs
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d98decf326acae85fe4bb758ca760abcd0caf5f7

commit d98decf326acae85fe4bb758ca760abcd0caf5f7
Author: tsergeant <tsergeant@chromium.org>
Date: Wed May 25 07:48:39 2016

Roll Polymer elements

In particular, this adds the 0.9.0 version of app-layout and app-route
(formerly carbon-route), which we are planning to use in MD History.

BUG= 609502 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true # crisper.js

Review-Url: https://codereview.chromium.org/1984963002
Cr-Commit-Position: refs/heads/master@{#395826}

[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/bower.json
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-box/app-box-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-box/app-box.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-box/compiled_resources2.gyp
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-drawer-layout/app-drawer-layout-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-drawer-layout/app-drawer-layout.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-drawer-layout/compiled_resources2.gyp
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-drawer/app-drawer-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-drawer/app-drawer.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-drawer/compiled_resources2.gyp
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-header-layout/app-header-layout-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-header-layout/app-header-layout.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-header-layout/compiled_resources2.gyp
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-header/app-header-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-header/app-header.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-header/compiled_resources2.gyp
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-layout.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/app-scroll-effects-behavior-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/app-scroll-effects-behavior.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/app-scroll-effects.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/compiled_resources2.gyp
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/blend-background-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/blend-background.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/compiled_resources2.gyp
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/fade-background-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/fade-background.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/material-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/material.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/parallax-background-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/parallax-background.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/resize-snapped-title-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/resize-snapped-title.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/resize-title-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/resize-title.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/waterfall-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/waterfall.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scrollpos-control/app-scrollpos-control-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scrollpos-control/app-scrollpos-control.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-scrollpos-control/compiled_resources2.gyp
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-toolbar/app-toolbar-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-toolbar/app-toolbar.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/app-toolbar/compiled_resources2.gyp
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/bower.json
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/compiled_resources2.gyp
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/helpers/compiled_resources2.gyp
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/helpers/helpers-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-layout/helpers/helpers.html
[rename] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-route/app-location-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-route/app-location.html
[rename] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-route/app-route-converter-behavior-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-route/app-route-converter-behavior.html
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-route/app-route-converter-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-route/app-route-converter.html
[rename] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-route/app-route-extracted.js
[add] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-route/app-route.html
[rename] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-route/bower.json
[rename] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/app-route/compiled_resources2.gyp
[delete] https://crrev.com/449883eb67fb8e0a3b3325682d2db4a16f1cdbed/third_party/polymer/v1_0/components-chromium/carbon-route/carbon-location.html
[delete] https://crrev.com/449883eb67fb8e0a3b3325682d2db4a16f1cdbed/third_party/polymer/v1_0/components-chromium/carbon-route/carbon-route-converter.html
[delete] https://crrev.com/449883eb67fb8e0a3b3325682d2db4a16f1cdbed/third_party/polymer/v1_0/components-chromium/carbon-route/carbon-route.html
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-a11y-keys/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-a11y-keys/iron-a11y-keys-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-dropdown/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-fit-behavior/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-fit-behavior/iron-fit-behavior-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-location/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-location/iron-location-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/iron-menu-behavior-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-range-behavior/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-range-behavior/iron-range-behavior-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-selector/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/iron-selector/iron-selectable-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-button/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-button/compiled_resources2.gyp
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-button/paper-button-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-button/paper-button.html
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-checkbox/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-checkbox/paper-checkbox.html
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-radio-button/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button.html
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-radio-group/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-radio-group/compiled_resources2.gyp
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-radio-group/paper-radio-group-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-radio-group/paper-radio-group.html
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-slider/bower.json
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/find_unused_elements.py
[modify] https://crrev.com/d98decf326acae85fe4bb758ca760abcd0caf5f7/third_party/polymer/v1_0/rsync_exclude.txt

Blocking: 425625
Blocking: 619799
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/357edd888ea83097acfec6125c6cb478d2499d03

commit 357edd888ea83097acfec6125c6cb478d2499d03
Author: calamity <calamity@chromium.org>
Date: Wed Jul 20 04:32:36 2016

[MD History] Add routing to the history page.

This CL adds app-route to the Material Design History page so that
chrome://history/openTabs goes to the synced devices view and clicking
the synced devices button in the sidebar also modifies the location bar.

BUG= 609502 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2042973002
Cr-Commit-Position: refs/heads/master@{#406488}

[modify] https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03/chrome/browser/resources/md_history/history.html
[modify] https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03/chrome/browser/resources/md_history/side_bar.js
[add] https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03/chrome/test/data/webui/md_history/history_routing_test.js
[modify] https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03/chrome/test/data/webui/md_history/history_synced_tabs_test.js
[modify] https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03/chrome/test/data/webui/md_history/md_history_browsertest.js
[modify] https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03/third_party/polymer/v1_0/find_unused_elements.py
[modify] https://crrev.com/357edd888ea83097acfec6125c6cb478d2499d03/ui/webui/resources/polymer_resources.grdp

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e173b7e91a15b8414f12a8320675f0cc0ecbe8a

commit 7e173b7e91a15b8414f12a8320675f0cc0ecbe8a
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jul 21 05:27:57 2016

MD History: Fix appearance of 'Other forms of browsing history' link

crrev.com/406488 added extra styling for <a> tags in the side bar. This
also changed the appearance of the history.google.com link in the
sidebar footer. This CL changes the selectors so that these styles only
apply to the top-level links, as intended.

BUG= 609502 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2166733002
Cr-Commit-Position: refs/heads/master@{#406772}

[modify] https://crrev.com/7e173b7e91a15b8414f12a8320675f0cc0ecbe8a/chrome/browser/resources/md_history/side_bar.html

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e173b7e91a15b8414f12a8320675f0cc0ecbe8a

commit 7e173b7e91a15b8414f12a8320675f0cc0ecbe8a
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jul 21 05:27:57 2016

MD History: Fix appearance of 'Other forms of browsing history' link

crrev.com/406488 added extra styling for <a> tags in the side bar. This
also changed the appearance of the history.google.com link in the
sidebar footer. This CL changes the selectors so that these styles only
apply to the top-level links, as intended.

BUG= 609502 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2166733002
Cr-Commit-Position: refs/heads/master@{#406772}

[modify] https://crrev.com/7e173b7e91a15b8414f12a8320675f0cc0ecbe8a/chrome/browser/resources/md_history/side_bar.html

Sign in to add a comment