DataReductionProxyTestContext::Builder is using a real HostResolverImpl |
||||
Issue descriptionIt should be using a MockHostResolver to avoid making real DNS requests. Overriding the HostResolverProc works as well, but can result in a leak (It uses a worker pool). There's currently a suppression for the leak, but I'm removing it (Reworking the leaking code, but it will still leak, MockHostResolver doesn't have that issue). I'd suggest just switching the class over to using TestURLRequestContext, to avoid this issue. For now, I'm just going to switch it over to the MockHostResolver so I'm not blocking on it.
,
Jul 27 2016
Forgot about this. I ended up using another approach to work around the issue to get my code change through. Looks like DataReductionProxyTestContext::Builder is indeed used in tests that make network requests. Those requests correctly use mock sockets...But I believe they use real DNS lookups, like DataReductionProxyInterceptorEndToEndTest::ResponseWithoutRetry, which I think depends on foo.com having a real DNS entry, which is a problem.
,
Oct 28 2016
,
Jan 11 2017
DataReductionProxyInterceptorEndToEndTest and DataReductionProxyBypassStatsTest already use TestURLRequestContext which uses MockHostResolver for resolving. No changes needed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bengr@chromium.org
, May 12 2016