New issue
Advanced search Search tips

Issue 609488 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 609122



Sign in to add a comment

Standardize naming in Web APKs

Project Member Reported by pkotw...@chromium.org, May 5 2016

Issue description

Standardize naming in Web APKs

In comments: WebAPK
Java file names: SomethingWebApkSomething.java
C++ file names: something_webapk_something.cc
Package: org.chromium.webapk

 
Blocking: 609122
Cc: hanxi@chromium.org yfried...@chromium.org
Labels: -Pri-3 OS-Android Pri-2
Owner: pkotw...@chromium.org
Status: Started (was: Untriaged)
The following revision refers to this bug:
https://chromium.googlesource.com/experimental/chromium/src/+/4119681

Remove unused IMintedApiCallback

BUG= 609488 

Review URL: https://codereview.chromium.org/1951053003/
The following revision refers to this bug:
https://chromium.googlesource.com/experimental/chromium/src/+/8f1919c

Rename WebAPK related classes to be of the format *WebApk*.java

BUG= 609488 

Review URL: https://codereview.chromium.org/1953543002
The following revision refers to this bug:
https://chromium.googlesource.com/experimental/chromium/src/+/5580f94

Change webapk packages and directory structure

This CL:
- Changes toplevel directory from web_apks/minting_example to webapk/
- Moves code for "Web APK shell" from web_apks/minting_example/src to webapk/shell_apk/src
- Creates a BUILD.gn build file for each subdirectory
- Replaces org.chromium.minting package with org.chromium.webapk

BUG= 609488 

Review URL: https://codereview.chromium.org/1945303005
The following revision refers to this bug:
https://chromium.googlesource.com/experimental/chromium/src/+/dd0efaa

Rename shell_apk to webapk

I think that "webapk" is an easier GN target to remember than "shell_apk"

BUG= 609488 

Review URL: https://codereview.chromium.org/1956593002/
The following revision refers to this bug:
https://chromium.googlesource.com/experimental/chromium/src/+/890ce6e0

Rename org.chromium.minting to org.chromium.webapk that I missed in https://codereview.chromium.org/1945303005/

BUG= 609488 

Review URL: https://codereview.chromium.org/1946333006/
The following revision refers to this bug:
https://chromium.googlesource.com/experimental/chromium/src/+/b9646cf

Rename MintingExample.template.apk to WebApk.template.apk

BUG= 609488 

Review URL: https://codereview.chromium.org/1948033005/
The following revision refers to this bug:
https://chromium.googlesource.com/experimental/chromium/src/+/00a5475

Make WebAPK naming consistent 1/2

This CL makes the naming more consistent.
- Comments use WebAPK (not WebAPK, WebApk etc)
- Function names use WebApk
  e.g void makeWebApk() {}
- C++ variable names use webapk
  e.g. std::string webapk_package_name = "";

BUG= 609488 

Review URL: https://codereview.chromium.org/1958523002/
The following revision refers to this bug:
https://chromium.googlesource.com/experimental/chromium/src/+/a4e396d

Make WebAPK naming consistent 2/2

This CL fixes up the remaining occurences of "minting" in //webapk

BUG= 609488 

Review URL: https://codereview.chromium.org/1953013003/
Status: Fixed (was: Started)

Sign in to add a comment