New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609487 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 584266



Sign in to add a comment

Push snippets below the fold for both snap positions

Project Member Reported by mcwilliams@chromium.org, May 5 2016

Issue description

Snippets need to be pushed below the fold minus the peeking card when most likely is fully rendered, and when the second snap occurs when most likely are not fully rendered on initial load
 
Components: UI>Browser>NewTabPage
Project Member

Comment 2 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4d6b032de178f2a2a6f9beff8d7067c07970b8

commit 1c4d6b032de178f2a2a6f9beff8d7067c07970b8
Author: mcwilliams <mcwilliams@chromium.org>
Date: Thu May 05 23:48:03 2016

Peeking cards

Pin the snippets to the bottom of the page and introduce a peeking card to indicate to the user there is something at the bottom of the page. When scrolling up transition the peeking card into a full bleed card.

BUG= 586126 ,  609487 

Review-Url: https://codereview.chromium.org/1947263003
Cr-Commit-Position: refs/heads/master@{#391955}

[modify] https://crrev.com/1c4d6b032de178f2a2a6f9beff8d7067c07970b8/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
[modify] https://crrev.com/1c4d6b032de178f2a2a6f9beff8d7067c07970b8/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/1c4d6b032de178f2a2a6f9beff8d7067c07970b8/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
[modify] https://crrev.com/1c4d6b032de178f2a2a6f9beff8d7067c07970b8/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java
[modify] https://crrev.com/1c4d6b032de178f2a2a6f9beff8d7067c07970b8/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/1c4d6b032de178f2a2a6f9beff8d7067c07970b8/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/1c4d6b032de178f2a2a6f9beff8d7067c07970b8/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
[modify] https://crrev.com/1c4d6b032de178f2a2a6f9beff8d7067c07970b8/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java
[modify] https://crrev.com/1c4d6b032de178f2a2a6f9beff8d7067c07970b8/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

Owner: peconn@chromium.org
Peeking cards is at the bottom for fully rendered NTP on initial load, Peter will look at the 2nd snap point peg to the bottom
I just looked at the latest build. What's remaining here?
When we can't see Most Likely fully when scrolled to the top, we add Most Likely as a 3rd snap point.

When we have snapped to this snap point, the peeking card isn't necessarily in the correct position (we're getting lucky at the moment and it looks about right by chance).

Comment 6 by fi...@chromium.org, May 10 2016

Blocking: 584266

Comment 8 by peconn@chromium.org, May 16 2016

Status: Fixed (was: Assigned)

Comment 9 by fi...@chromium.org, Jul 1 2016

Labels: zine-mr-MVP

Comment 10 by finkm@google.com, Jul 1 2016

Labels: -zine-mr-mvp
Labels: zine-mr-MVP

Sign in to add a comment