New issue
Advanced search Search tips

Issue 609472 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Jun 2016
Cc:
qyears...@chromium.org
dpranke@chromium.org
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove builders.rebaseline_override_dirs if unused

Project Member Reported by bokan@chromium.org, May 5 2016 
dpranke@ says we no longer use this method but it's still referenced from rebaseline.py, ultimately used in RebaselineTest and CopyExistingBaselinesInternal. These may be dead code paths that we can remove.

Comment 1 by qyears...@chromium.org, May 10 2016

Cc: qyears...@chromium.org
Summary: Remove builders.rebaseline_override_dirs if unused (was: Check if builders.rebaseline_override_dirs is actually used)
If it's not in any builders lists, then in theory the branch at https://chromium.googlesource.com/chromium/src/+/095ed01/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py#107 should never be followed so it should be safe to remove that.

Comment 2 by qyears...@chromium.org, Jun 20 2016

Owner: qyears...@chromium.org
Status: Fixed (was: Available)
Removed by https://codereview.chromium.org/2006333003/
►

Sign in to add a comment