New issue
Advanced search Search tips

Issue 609448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

WebViewLayoutTest#testWebViewExcludedInterfaces is failing

Project Member Reported by mlamouri@chromium.org, May 5 2016

Issue description

https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20L%20%28dbg%29/builds/12956

Error message is:
I  105.470s run_tests_on_device(0d88c4e143e4bab5)    Failure in testWebViewExcludedInterfaces:
I  105.470s run_tests_on_device(0d88c4e143e4bab5)    junit.framework.AssertionFailedError: Interface [GLOBAL OBJECT].method onerror not exposed in blink
I  105.470s run_tests_on_device(0d88c4e143e4bab5)    	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewExcludedInterfaces(WebViewLayoutTest.java:150)
I  105.470s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
I  105.471s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
I  105.471s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
I  105.471s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I  105.471s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I  105.471s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
I  105.471s run_tests_on_device(0d88c4e143e4bab5)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
I  105.472s run_tests_on_device(0d88c4e143e4bab5)    
I  105.472s run_tests_on_device(0d88c4e143e4bab5)    INSTRUMENTATION_STATUS: id=InstrumentationTestRunner
I  105.472s run_tests_on_device(0d88c4e143e4bab5)    INSTRUMENTATION_STATUS: test=testWebViewExcludedInterfaces
I  105.472s run_tests_on_device(0d88c4e143e4bab5)    INSTRUMENTATION_STATUS: class=org.chromium.webview_shell.test.WebViewLayoutTest
I  105.472s run_tests_on_device(0d88c4e143e4bab5)    INSTRUMENTATION_STATUS: stack=junit.framework.AssertionFailedError: Interface [GLOBAL OBJECT].method onerror not exposed in blink
I  105.472s run_tests_on_device(0d88c4e143e4bab5)    	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewExcludedInterfaces(WebViewLayoutTest.java:150)
I  105.472s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
I  105.473s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
I  105.473s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
I  105.473s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I  105.473s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I  105.473s run_tests_on_device(0d88c4e143e4bab5)    	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
I  105.473s run_tests_on_device(0d88c4e143e4bab5)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)


Tim, could you investigate and send a fix? Would be great to make sure it's the last one there :)
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1ef7ba0f99e5538922ae9c936ffba2138c8bdf9

commit f1ef7ba0f99e5538922ae9c936ffba2138c8bdf9
Author: timvolodine <timvolodine@chromium.org>
Date: Thu May 05 15:05:12 2016

[WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces.

Fix exclude list due to https://codereview.chromium.org/1380503002

Should fix WebView L and WebView M AOSP bots.

BUG= 608979 , 609448 

Review-Url: https://codereview.chromium.org/1951253003
Cr-Commit-Position: refs/heads/master@{#391803}

[modify] https://crrev.com/f1ef7ba0f99e5538922ae9c936ffba2138c8bdf9/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt

It looks like https://codereview.chromium.org/1380503002 was reverted in https://codereview.chromium.org/1958883003 and now the bots
Android Webview L (dbg)
and
Android Webview M (dbg)
are failing the tests
org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewExcludedInterfaces
org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewIncludedStableInterfaces

link to one of the failing builds:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20L%20%28dbg%29/builds/13115


output:

I  122.401s Main  FINISHED TRY #3/3
I  122.401s Main  2 failed tests remain.
C  122.401s Main  ********************************************************************************
C  122.401s Main  Detailed Logs
C  122.401s Main  ********************************************************************************
C  122.402s Main  [FAIL] org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewExcludedInterfaces:
C  122.402s Main  junit.framework.AssertionFailedError: Interface [GLOBAL OBJECT].getter speechSynthesis not exposed in blink
C  122.402s Main  	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewExcludedInterfaces(WebViewLayoutTest.java:150)
C  122.402s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C  122.402s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C  122.402s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C  122.402s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  122.402s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  122.402s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C  122.402s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
C  122.403s Main  
C  122.403s Main  [FAIL] org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewIncludedStableInterfaces:
C  122.403s Main  junit.framework.ComparisonFailure: Missing webview interfaces found expected:<[]> but was:<[[GLOBAL OBJECT].attribute speechSynthesis
C  122.403s Main  [GLOBAL OBJECT].method onerror
C  122.403s Main  ]>
C  122.403s Main  	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewIncludedStableInterfaces(WebViewLayoutTest.java:202)
C  122.403s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C  122.403s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C  122.403s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C  122.403s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  122.403s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  122.403s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C  122.403s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
C  122.404s Main  ********************************************************************************
C  122.404s Main  Summary



(these two bots have only failed once but since they are failing at the same time I'm assuming this is not a flake)
Alright, chatted to Tim and I should be reverting
https://codereview.chromium.org/1951253003
and
https://codereview.chromium.org/1950943002
to fix the current failures.
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4497b8860b781fa97da812edfbffa64ef27f1e4

commit a4497b8860b781fa97da812edfbffa64ef27f1e4
Author: gsennton <gsennton@chromium.org>
Date: Mon May 09 16:34:34 2016

Revert of [Sheriff] Fix WebViewLayoutTest regarding global interface expectations. (patchset #1 id:1 of https://codereview.chromium.org/1950943002/ )

Reason for revert:
Fix WebViewLayoutTest failures due to https://codereview.chromium.org/1380503002 being reverted.

Thus, to fix this we need to revert the current CL and https://codereview.chromium.org/1951253003

BUG= 609448 

Original issue's description:
> [Sheriff] Fix WebViewLayoutTest regarding global interface expectations.
>
> The expectation file assume speechSynthesis is an attribute but its now
> a getter.
>
> BUG= 609100 
> R=timvolodine@chromium.org
>
> Committed: https://crrev.com/e3168773cb69e2a78acce39d1b4c1adbf56cac87
> Cr-Commit-Position: refs/heads/master@{#391504}

TBR=timvolodine@chromium.org,mlamouri@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 609100 

Review-Url: https://codereview.chromium.org/1960923003
Cr-Commit-Position: refs/heads/master@{#392335}

[modify] https://crrev.com/a4497b8860b781fa97da812edfbffa64ef27f1e4/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt

Project Member

Comment 6 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90cdf6675f4f91aa68fb12709c46eac1a658dc3d

commit 90cdf6675f4f91aa68fb12709c46eac1a658dc3d
Author: gsennton <gsennton@chromium.org>
Date: Mon May 09 17:02:31 2016

Revert of [WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces. (patchset #2 id:20001 of https://codereview.chromium.org/1951253003/ )

Reason for revert:
Fix WebViewLayoutTest failures due to https://codereview.chromium.org/1380503002 being reverted.

Reverting the current CL and  https://codereview.chromium.org/1950943002/ (that revert is in https://codereview.chromium.org/1960923003/)

BUG= 609448 

Original issue's description:
> [WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces.
>
> Fix exclude list due to https://codereview.chromium.org/1380503002
>
> Should fix WebView L and WebView M AOSP bots.
>
> BUG= 608979 , 609448 
>
> Committed: https://crrev.com/f1ef7ba0f99e5538922ae9c936ffba2138c8bdf9
> Cr-Commit-Position: refs/heads/master@{#391803}

TBR=mlamouri@chromium.org,torne@chromium.org,timvolodine@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 608979 , 609448 

Review-Url: https://codereview.chromium.org/1960203002
Cr-Commit-Position: refs/heads/master@{#392340}

[modify] https://crrev.com/90cdf6675f4f91aa68fb12709c46eac1a658dc3d/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt

Status: Fixed (was: Started)

Sign in to add a comment