New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609441 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 614686



Sign in to add a comment

Security Panel: Links to the network panel produce invalid filters

Reported by kdzwinel@gmail.com, May 5 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2724.0 Safari/537.36

Steps to reproduce the problem:
1. Open DevTools
2. Go to the network tab
3. Select 'Font' as a filter
4. Check 'Regex' box
4. Go to the security tab
5. Click one of the origins
6. Click 'view requests in Network Panel'

What is the expected behavior?
User should be redirected to the Network Panel where they can see relevant resources.

What went wrong?
Network panel opens, but the list is empty.

Did this work before? No 

Chrome version: 52.0.2724.0  Channel: n/a
OS Version: OS X 10.11.4
Flash Version: 

There are two bugs here:

1. Invalid filter is produced ("domain:www.google.plscheme:https" - missing space)
2. 'Regex' and 'Font' options are not being reset
 
Screen Shot 2016-05-05 at 12.52.42.png
39.4 KB View Download
Screen Shot 2016-05-05 at 12.52.34.png
82.7 KB View Download
Cc: kavvaru@chromium.org
Components: Platform>DevTools>Network
Labels: Needs-Feedback
Unable to reproduce the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.4 using chrome version 50.0.2661.94 and canary 52.0.2725.0 with the below steps

1. Go to Network tab in dev tools.
2.Select font and regex check box
3.Go to security tab and selected one origin
4.Clicked on view requests in network panel link 
5.redirected to network tab, able to see the corresponding origin name in filter text box and able to see the list

Please find the attached screen cast and confirm anything missed here.
Request you please try the issue by upgrading chrome to latest canary and update the thread if the issue still persists.
Please provide us any expected screen shot would help us for better triaging the issue.

Thanks,
609441.mp4
1.2 MB Download

Comment 2 by alph@chromium.org, May 6 2016

Owner: allada@chromium.org
Labels: -Needs-Feedback
Status: Available (was: Unconfirmed)
Yes, when the user clicks on "View Requests in Network Panel" it should uncheck the Regex box if it is checked.

Comment 4 by kdzwinel@gmail.com, May 6 2016

@kavvaru - your video shows both issues that I mentioned:
1) filter is invalid (note missing space between "gstatic.com" and "scheme")
2) Regex and Font filters are checked (should be unchecked)
As a result, there are no resources shown on the list below as there should be.

However, I just tested ToT and it looks like first issue was fixed. Second one is still valid though.

@allada IMO both "regex" and "resource filter" should get unchecked.

Comment 5 by allada@chromium.org, May 24 2016

Status: Started (was: Available)

Comment 6 by allada@chromium.org, May 25 2016

Blocking: 614686
Project Member

Comment 7 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdf66f4f2270f5e5fbe8b45f9f53a87f268614ab

commit cdf66f4f2270f5e5fbe8b45f9f53a87f268614ab
Author: allada <allada@chromium.org>
Date: Fri May 27 04:35:37 2016

[Devtools] Proper filter set from panel jump into network panel

Made it so when link is clicked that jumps and pre-filters results
in the network panel it now properly adjusts regex and other filters.

BUG= 609441 
R=lushnikov

Review-Url: https://codereview.chromium.org/2006143004
Cr-Commit-Position: refs/heads/master@{#396383}

[modify] https://crrev.com/cdf66f4f2270f5e5fbe8b45f9f53a87f268614ab/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/cdf66f4f2270f5e5fbe8b45f9f53a87f268614ab/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
[modify] https://crrev.com/cdf66f4f2270f5e5fbe8b45f9f53a87f268614ab/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

Comment 8 by allada@chromium.org, May 27 2016

Status: Fixed (was: Started)

Sign in to add a comment