Issue metadata
Sign in to add a comment
|
Regression: Logo misplaced is observed on ‘Feedback overlay’ of ‘Usabilla.com’
Reported by
dmascare...@etouch.net,
May 5 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:52.0.2725.0 (Official Build) 3bfc96772d01d42a50683cae507a53cf07bb606d-refs/heads/master@{#391707} 32/64 bit Os:Mac (10.10.5),Mac Pro(10.11.4),Mac Retina (10.11.4) What steps will reproduce the problem? 1. Launch chrome and navigate to above url. 2. Click on ‘Feedback’ button seen beside scrollbar and observe. Actual: Logo misplaced is observed on ‘Feedback overlay’ Expected: Logo should not be misplaced. This is regression issue, broken in ‘M 52’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/38af02914e616fb15635cf0890b610870f578222..957ee1cf9558f59e65c943a85fab2ec7ce94ebe2?pretty=fuller&n=100 Suspecting: r389413 Good build:52.0.2715.0 Bad build:52.0.2716.0 Note:1. Issue is not reproducible on Windows and Linux Os. 2. Issue is not reproducible on other browser like Firefox.
,
May 5 2016
Looks like a float right clearing issue, would you mind taking a look Rob?
,
May 9 2016
Marking the above issue as RB-Stable as this is a recent regression. Thank you!
,
May 9 2016
I can't reproduce this on my Linux build so can't debug it - sorry!
,
May 10 2016
@robhogan: This issue is reproducible only on Mac and not on Windows & Linux as mentioned in the original bug. @eae: Re-assigning back to you can you please assign it to concern dev ? I really appreciate your help. Thank you!
,
May 13 2016
@robhogan: Friendly Ping!
,
May 13 2016
I think you meant to ping eae. :)
,
May 16 2016
Able to reproduce the issue on mac 10.11 chrome version 52.0.2738.0 @eae: Could you please route to appropriate dev
,
May 19 2016
Issue still persists on Mac 10.11.5 using 52.0.2341.0.
,
May 19 2016
It's broken on ToT linux for me.
,
May 19 2016
,
May 19 2016
You are probably looking for a change made after 389398 (known good), but no later than 389473 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/67d8ccb45177b214dbdb51375f1ed1ba31ffa07b..c7c0d3ab719b356d8ccef636506507b2cead7ff1 Probably https://chromium.googlesource.com/chromium/src/+/957ee1cf9558f59e65c943a85fab2ec7ce94ebe2
,
May 19 2016
,
May 19 2016
Identified the problem and have a fix in the works.
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60bec7228df8e6114c75586ed3e3a45042b713eb commit 60bec7228df8e6114c75586ed3e3a45042b713eb Author: eae <eae@chromium.org> Date: Fri May 20 01:39:00 2016 Represent lines using LayoutUnit in LineWidth Change LineWidth to represent m_availableWidth, m_left and m_right using LayoutUnits instead of floats. This matches the line box tree code as it uses LayoutUnits for line boxes. Further it solves a line breaking issue for floating elements due to a loss of precision when converting between LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor. This should allow the remaining use of LayoutUnit::epsilon to be removed as well but given the sensitive nature of this code I'd rather make that change in a separate and subsequent CL. R=szager@chromium.org BUG= 609427 TEST=fast/sub-pixel/float-subpixel-wrapping.html Review-Url: https://codereview.chromium.org/1995103002 Cr-Commit-Position: refs/heads/master@{#394955} [add] https://crrev.com/60bec7228df8e6114c75586ed3e3a45042b713eb/third_party/WebKit/LayoutTests/fast/sub-pixel/float-subpixel-wrapping-expected.html [add] https://crrev.com/60bec7228df8e6114c75586ed3e3a45042b713eb/third_party/WebKit/LayoutTests/fast/sub-pixel/float-subpixel-wrapping.html [modify] https://crrev.com/60bec7228df8e6114c75586ed3e3a45042b713eb/third_party/WebKit/Source/core/layout/line/LineWidth.cpp [modify] https://crrev.com/60bec7228df8e6114c75586ed3e3a45042b713eb/third_party/WebKit/Source/core/layout/line/LineWidth.h
,
May 20 2016
,
May 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/962b873a492c8036c0286bb55b8c950b31fe866b commit 962b873a492c8036c0286bb55b8c950b31fe866b Author: eae <eae@chromium.org> Date: Sat May 21 02:04:19 2016 Change LineWidth::fitsOnLine comparison logic Change the LineWidth::fitsOnLine comparison logic to ceil to LayoutUnits instead of adding LayoutUnit::epsilon now that m_availableWidth has been changed to a LayoutUnit instead of a float. R=szager@chromium.org BUG= 609427 Review-Url: https://codereview.chromium.org/1995083003 Cr-Commit-Position: refs/heads/master@{#395230} [modify] https://crrev.com/962b873a492c8036c0286bb55b8c950b31fe866b/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/962b873a492c8036c0286bb55b8c950b31fe866b/third_party/WebKit/Source/core/layout/line/LineWidth.h
,
May 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/456137befe06adbf6894de47770909129c5c0f07 commit 456137befe06adbf6894de47770909129c5c0f07 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Sat May 21 03:24:52 2016 Auto-rebaseline for r395230 https://chromium.googlesource.com/chromium/src/+/962b873a4 BUG= 609427 TBR=eae@chromium.org Review URL: https://codereview.chromium.org/2004713002 . Cr-Commit-Position: refs/heads/master@{#395246} [modify] https://crrev.com/456137befe06adbf6894de47770909129c5c0f07/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/456137befe06adbf6894de47770909129c5c0f07/third_party/WebKit/LayoutTests/platform/mac/css1/color_and_background/background_position-expected.txt [modify] https://crrev.com/456137befe06adbf6894de47770909129c5c0f07/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-at-end-of-line-expected.png [modify] https://crrev.com/456137befe06adbf6894de47770909129c5c0f07/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-at-end-of-line-expected.txt [modify] https://crrev.com/456137befe06adbf6894de47770909129c5c0f07/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-at-end-of-line-expected.png [modify] https://crrev.com/456137befe06adbf6894de47770909129c5c0f07/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-at-end-of-line-expected.txt
,
May 23 2016
,
May 23 2016
(the merge request is for r394955 specifically which missed the cut by 16 revisions)
,
May 23 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65cba364286f30178fba4c25801604a7a8957e7f commit 65cba364286f30178fba4c25801604a7a8957e7f Author: Emil A Eklund <eae@chromium.org> Date: Mon May 23 20:51:05 2016 Represent lines using LayoutUnit in LineWidth Change LineWidth to represent m_availableWidth, m_left and m_right using LayoutUnits instead of floats. This matches the line box tree code as it uses LayoutUnits for line boxes. Further it solves a line breaking issue for floating elements due to a loss of precision when converting between LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor. This should allow the remaining use of LayoutUnit::epsilon to be removed as well but given the sensitive nature of this code I'd rather make that change in a separate and subsequent CL. R=szager@chromium.org BUG= 609427 TEST=fast/sub-pixel/float-subpixel-wrapping.html Review-Url: https://codereview.chromium.org/1995103002 Cr-Commit-Position: refs/heads/master@{#394955} (cherry picked from commit 60bec7228df8e6114c75586ed3e3a45042b713eb) Review URL: https://codereview.chromium.org/2003173002 . Cr-Commit-Position: refs/branch-heads/2743@{#20} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [add] https://crrev.com/65cba364286f30178fba4c25801604a7a8957e7f/third_party/WebKit/LayoutTests/fast/sub-pixel/float-subpixel-wrapping-expected.html [add] https://crrev.com/65cba364286f30178fba4c25801604a7a8957e7f/third_party/WebKit/LayoutTests/fast/sub-pixel/float-subpixel-wrapping.html [modify] https://crrev.com/65cba364286f30178fba4c25801604a7a8957e7f/third_party/WebKit/Source/core/layout/line/LineWidth.cpp [modify] https://crrev.com/65cba364286f30178fba4c25801604a7a8957e7f/third_party/WebKit/Source/core/layout/line/LineWidth.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dmascare...@etouch.net
, May 5 2016