New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609427 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Logo misplaced is observed on ‘Feedback overlay’ of ‘Usabilla.com’

Reported by dmascare...@etouch.net, May 5 2016

Issue description

Chrome Version:52.0.2725.0 (Official Build) 3bfc96772d01d42a50683cae507a53cf07bb606d-refs/heads/master@{#391707} 32/64 bit
Os:Mac (10.10.5),Mac Pro(10.11.4),Mac Retina (10.11.4)

What steps will reproduce the problem?
1. Launch chrome and navigate to above url.
2. Click on ‘Feedback’ button seen beside scrollbar and observe.

Actual:  Logo misplaced is observed on ‘Feedback overlay’
Expected: Logo should not be misplaced.

This is regression issue, broken in  ‘M 52’ and below is narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/38af02914e616fb15635cf0890b610870f578222..957ee1cf9558f59e65c943a85fab2ec7ce94ebe2?pretty=fuller&n=100

Suspecting: r389413 

Good build:52.0.2715.0
Bad build:52.0.2716.0

Note:1. Issue is not reproducible on Windows and Linux Os.
     2. Issue is not reproducible on other browser like Firefox.
 
icon.png
72.7 KB View Download

Comment 2 by e...@chromium.org, May 5 2016

Owner: robho...@gmail.com
Looks like a float right clearing issue, would you mind taking a look Rob?
Labels: ReleaseBlock-Stable
Marking the above issue as RB-Stable as this is a recent regression.

Thank you!
Cc: robho...@gmail.com
Owner: dmascare...@etouch.net
I can't reproduce this on my Linux build so can't debug it - sorry!
Cc: dmascare...@etouch.net
Owner: e...@chromium.org
@robhogan: This issue is reproducible only on Mac and not on Windows & Linux as mentioned in the original bug.

@eae: Re-assigning back to you can you please assign it to concern dev ?

I really appreciate your help.

Thank you!
@robhogan: Friendly Ping!
I think you meant to ping eae. :)
Cc: tkonch...@chromium.org
Able to reproduce the issue on mac 10.11 chrome version 52.0.2738.0

@eae: Could you please route to appropriate dev
Issue still persists on Mac 10.11.5 using 52.0.2341.0.
It's broken on ToT linux for me.

Comment 11 by e...@chromium.org, May 19 2016

Status: Started (was: Assigned)

Comment 12 by e...@chromium.org, May 19 2016

You are probably looking for a change made after 389398 (known good), but no later than 389473 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/67d8ccb45177b214dbdb51375f1ed1ba31ffa07b..c7c0d3ab719b356d8ccef636506507b2cead7ff1

Probably 
https://chromium.googlesource.com/chromium/src/+/957ee1cf9558f59e65c943a85fab2ec7ce94ebe2

Comment 13 by e...@chromium.org, May 19 2016

Labels: -OS-Mac OS-All

Comment 14 by e...@chromium.org, May 19 2016

Identified the problem and have a fix in the works.
Project Member

Comment 15 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60bec7228df8e6114c75586ed3e3a45042b713eb

commit 60bec7228df8e6114c75586ed3e3a45042b713eb
Author: eae <eae@chromium.org>
Date: Fri May 20 01:39:00 2016

Represent lines using LayoutUnit in LineWidth

Change LineWidth to represent m_availableWidth, m_left and m_right using
LayoutUnits instead of floats. This matches the line box tree code as it
uses LayoutUnits for line boxes. Further it solves a line breaking issue
for floating elements due to a loss of precision when converting between
LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor.

This should allow the remaining use of LayoutUnit::epsilon to be removed
as well but given the sensitive nature of this code I'd rather make that
change in a separate and subsequent CL.

R=szager@chromium.org
BUG= 609427 
TEST=fast/sub-pixel/float-subpixel-wrapping.html

Review-Url: https://codereview.chromium.org/1995103002
Cr-Commit-Position: refs/heads/master@{#394955}

[add] https://crrev.com/60bec7228df8e6114c75586ed3e3a45042b713eb/third_party/WebKit/LayoutTests/fast/sub-pixel/float-subpixel-wrapping-expected.html
[add] https://crrev.com/60bec7228df8e6114c75586ed3e3a45042b713eb/third_party/WebKit/LayoutTests/fast/sub-pixel/float-subpixel-wrapping.html
[modify] https://crrev.com/60bec7228df8e6114c75586ed3e3a45042b713eb/third_party/WebKit/Source/core/layout/line/LineWidth.cpp
[modify] https://crrev.com/60bec7228df8e6114c75586ed3e3a45042b713eb/third_party/WebKit/Source/core/layout/line/LineWidth.h

Comment 16 by e...@chromium.org, May 20 2016

Status: Fixed (was: Started)
Project Member

Comment 17 by bugdroid1@chromium.org, May 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/962b873a492c8036c0286bb55b8c950b31fe866b

commit 962b873a492c8036c0286bb55b8c950b31fe866b
Author: eae <eae@chromium.org>
Date: Sat May 21 02:04:19 2016

Change LineWidth::fitsOnLine comparison logic

Change the LineWidth::fitsOnLine comparison logic to ceil to LayoutUnits
instead of adding LayoutUnit::epsilon now that m_availableWidth has been
changed to a LayoutUnit instead of a float.

R=szager@chromium.org
BUG= 609427 

Review-Url: https://codereview.chromium.org/1995083003
Cr-Commit-Position: refs/heads/master@{#395230}

[modify] https://crrev.com/962b873a492c8036c0286bb55b8c950b31fe866b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/962b873a492c8036c0286bb55b8c950b31fe866b/third_party/WebKit/Source/core/layout/line/LineWidth.h

Project Member

Comment 18 by bugdroid1@chromium.org, May 21 2016

Comment 19 by e...@chromium.org, May 23 2016

Labels: Merge-Request-52

Comment 20 by e...@chromium.org, May 23 2016

(the merge request is for r394955 specifically which missed the cut by 16 revisions)

Comment 21 by tin...@google.com, May 23 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 22 by bugdroid1@chromium.org, May 23 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65cba364286f30178fba4c25801604a7a8957e7f

commit 65cba364286f30178fba4c25801604a7a8957e7f
Author: Emil A Eklund <eae@chromium.org>
Date: Mon May 23 20:51:05 2016

Represent lines using LayoutUnit in LineWidth

Change LineWidth to represent m_availableWidth, m_left and m_right using
LayoutUnits instead of floats. This matches the line box tree code as it
uses LayoutUnits for line boxes. Further it solves a line breaking issue
for floating elements due to a loss of precision when converting between
LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor.

This should allow the remaining use of LayoutUnit::epsilon to be removed
as well but given the sensitive nature of this code I'd rather make that
change in a separate and subsequent CL.

R=szager@chromium.org
BUG= 609427 
TEST=fast/sub-pixel/float-subpixel-wrapping.html

Review-Url: https://codereview.chromium.org/1995103002
Cr-Commit-Position: refs/heads/master@{#394955}
(cherry picked from commit 60bec7228df8e6114c75586ed3e3a45042b713eb)

Review URL: https://codereview.chromium.org/2003173002 .

Cr-Commit-Position: refs/branch-heads/2743@{#20}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[add] https://crrev.com/65cba364286f30178fba4c25801604a7a8957e7f/third_party/WebKit/LayoutTests/fast/sub-pixel/float-subpixel-wrapping-expected.html
[add] https://crrev.com/65cba364286f30178fba4c25801604a7a8957e7f/third_party/WebKit/LayoutTests/fast/sub-pixel/float-subpixel-wrapping.html
[modify] https://crrev.com/65cba364286f30178fba4c25801604a7a8957e7f/third_party/WebKit/Source/core/layout/line/LineWidth.cpp
[modify] https://crrev.com/65cba364286f30178fba4c25801604a7a8957e7f/third_party/WebKit/Source/core/layout/line/LineWidth.h

Sign in to add a comment