Issue metadata
Sign in to add a comment
|
Regression: Favicons are seen missing in chrome://extensions after enabling material design |
||||||||||||||||||||||
Issue descriptionVersion:52.0.2725.0 dev OS: Ubuntu 12.04,14.04,windows Pre-condition: Enable Material design extensions from chrome://flags What steps will reproduce the problem? (1) Launch chrome and go to chrome://extensions and observe for favicons of extensions/chrome apps/load unpacked extensions[after checking developer mode] Expected: Favicons should be seen in chrome://extensions. Actual: Instead favicons are seen in missing. This is a regression issue broken in M52. Good Build: 52.0.2724.0 dev Bad Build: 52.0.2725.0 dev
,
May 5 2016
CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/e3c0fa5eeb231db1adc458ba49f84e55b67fe503..737b128f6945bd40959db05e8abec9012076a247 Suspecting https://codereview.chromium.org/1947533002 from changelog @michaelpg: Please confirm the issue.
,
May 5 2016
I think #2 is correct, but the *real* issue is that MD extensions never imported chrome://resources/polymer/v1_0/iron-icons/iron-icons.html even though it used icons from there. Removing that import from cr_search_field.html indirectly removed it from MD extensions. Fix up at https://codereview.chromium.org/1950303002.
,
May 5 2016
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ad53bd9dcd6407673274e99e04bb92dee46942b commit 9ad53bd9dcd6407673274e99e04bb92dee46942b Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Thu May 05 21:34:17 2016 [MD Extensions]: Fix sidebar icons sidebar.html relied on iron-icons but didn't include them. Add the missing import and a general regression test. BUG=529395 BUG= 609424 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1951323002 Cr-Commit-Position: refs/heads/master@{#391905} [modify] https://crrev.com/9ad53bd9dcd6407673274e99e04bb92dee46942b/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/9ad53bd9dcd6407673274e99e04bb92dee46942b/chrome/browser/resources/md_extensions/sidebar.html [modify] https://crrev.com/9ad53bd9dcd6407673274e99e04bb92dee46942b/chrome/test/data/webui/extensions/extension_detail_view_test.js [modify] https://crrev.com/9ad53bd9dcd6407673274e99e04bb92dee46942b/chrome/test/data/webui/extensions/extension_sidebar_test.js [modify] https://crrev.com/9ad53bd9dcd6407673274e99e04bb92dee46942b/chrome/test/data/webui/extensions/extension_test_util.js
,
May 12 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, May 5 2016Status: Untriaged (was: Unconfirmed)