New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609420 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Findit] Try jobs returning report with empty results but nonzero regression range size do not register as error

Project Member Reported by lijeffrey@chromium.org, May 5 2016

Issue description

A try job's report such as

{
  "result": {}, 
  "metadata": {
    "regression_range_size": 3
  }
}

where regression_range_size is reported and > 0 yet result is an empty dict should be an unknown error.

Currently no error is detected in such cases, for example https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_variable/builds/71

 
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_variable_gn/builds/40 is the correct example, though the other link provided should also be accounted for
Project Member

Comment 2 by bugdroid1@chromium.org, May 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/1eb52debda33d5c79401e4f9a3b0e5924ef5675f

commit 1eb52debda33d5c79401e4f9a3b0e5924ef5675f
Author: lijeffrey <lijeffrey@chromium.org>
Date: Sat May 07 00:20:05 2016

[Findit] Adding more try job error detection

A few false negatives under completed try jobs actually had errors occur during execution, but not captured. This change checks the buildbucket response itself too for more hints as to what happened.

BUG= 609420 

Review-Url: https://codereview.chromium.org/1948093003

[modify] https://crrev.com/1eb52debda33d5c79401e4f9a3b0e5924ef5675f/appengine/findit/waterfall/monitor_try_job_pipeline.py
[modify] https://crrev.com/1eb52debda33d5c79401e4f9a3b0e5924ef5675f/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment