New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609398 link

Starred by 28 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression

Blocked on:
issue 504133



Sign in to add a comment

REGRESSION: User Profile/Avatar icon overlaps/sticks together with Minimize button

Reported by yfulgaon...@etouch.net, May 5 2016

Issue description

Chrome version : 52.0.2725.0 (Official Build) 3bfc96772d01d42a50683cae507a53cf07bb606d-refs/heads/master@{#391707} 32/64 bit
OS :  Windows 7 (Aero enabled)

What steps will reproduce the problem?
1. Launch chrome, open NTP and observe the 'Avtar' icon.

Actual : The 'Avtar' icon appears to be sticked together with 'Minimize' button. (i.e no space is seen between 'avtar' icon and 'minimize' button.
Expected : Instead, there should be space in between 'Avtar' icon and 'Minimize' button.

This is a regression issue broken in 'M-52' and below is the manual regression and narrow bisect info.
Good Build :  52.0.2724.0
Bad Build :  52.0.2725.0

Narrow Bisect info:
https://chromium.googlesource.com/chromium/src/+log/3f4b4d4768e89310693fd187e4fb4f615662729e..2904b4c1645199880bf01151be7b75d8d13e5249?pretty=fuller&n=10000

Suspecting : r391595 from Narrow Bisect

Note: This is Windows 7 specific issue and not seen on Win (8,10), Mac and Linux OS
 
Actual_res.mp4
496 KB Download
Cc: pbomm...@chromium.org
Actual_screen shot.png
147 KB View Download
Labels: ReleaseBlock-Beta
Update: I am able to reproduce the above issue on Windows 10(Dell touch laptops, with Intel HD graphics 4600 card) on chrome version '52.0.2725.0' with slightly different behavior observed i.e. the profile button is getting overlapped on Maximize and Minimize buttons.

Bisect the above issue and found the same Narrow bisect and culprit.

I am marking the above issue as RB-BETA as user not able to perform Maximize and Minimize operations due to this overlapping on Windows 10.

Feel free to change the label accordingly.

Attach is the video for the same.


Thank you!



Here is the video. 
Windows 10Profile.mp4
1.4 MB Download
 Issue 609430  has been merged into this issue.
I've tried to reproduce this on Win8.1 & Win10 to no avail. Don't have a Win7 system to try yet. Working on getting something. I've used the latest dev and Canary (52.0.2725.0)

What version of Win 10 is being used? I'm using the latest preview build, 14332.
I have a Win7 machine with a repro (in KIR, alas). I'd be happy to try out some things if you have any suggestions for what to check.
I've gotten it to reproduce on Windows 7. None of my Windows 10 systems reproduce it.
For those reproducing this problem, what is the scaling factor you're using? >100%? On Win7, if I scale to 125%, the avatar button isn't where it's supposed to be.

Is there a problem with display::win::ScreenWin.ClientToDIPPoint()?
I've revered the patch which caused this problem. I will reland once the issue has been located and fixed.
I use 100%. If the window is maximized, the avatar button is flush with the minimize button. If the window is not maximized there's a few pixels of space between the avatar and minimize buttons.
I have this happening on Win 10 Home, version 1511, build 10586.218
HP Spectre X360
/high-dpi-support=1 /force-device-scale-factor=1
Cc: anthonyvd@chromium.org rogerta@chromium.org
 Issue 609833  has been merged into this issue.
Blockedon: 504133
Labels: -ReleaseBlock-Beta
just to update, not able to reproduce the issue on Dell Precision M3800(Touch) using Chrome Canary #52.0.2735.0

attached screenshot for reference, removing blocker label feel free to add if required.
609398_Win7.jpg
16.2 KB View Download
The change causing the regression was reverted. A new CL is being reviewed and should land soon. 
In my case the profile button actually covers the minimize button. I am not able to click the minimize button.
ccr.png
15.4 KB View Download
Project Member

Comment 17 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b25c378008aadbfb82c0066601372add9475b7af

commit b25c378008aadbfb82c0066601372add9475b7af
Author: kylixrd <kylixrd@chromium.org>
Date: Thu May 19 17:34:59 2016

Delay button bounds offset calculation until window is actually visible

BUG= 609398 

Review-Url: https://codereview.chromium.org/1992103002
Cr-Commit-Position: refs/heads/master@{#394806}

[modify] https://crrev.com/b25c378008aadbfb82c0066601372add9475b7af/chrome/browser/ui/views/frame/minimize_button_metrics_win.cc

Comment 18 by dhw@chromium.org, May 23 2016

Summary: REGRESSION: User Profile/Avatar icon overlaps/sticks together with Minimize button (was: Regression : The 'Avtar' icon appears to be sticked together with 'Minimize' button.)

Comment 19 by dhw@chromium.org, May 23 2016

 Issue 612817  has been merged into this issue.

Comment 20 by dhw@chromium.org, May 23 2016

 Issue 612838  has been merged into this issue.
Project Member

Comment 21 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
Not fixed. Problem continues when running Chrome latest W10 Anniversary edition. Believe it is a scaling issue because it does not appear when on my 4K laptop screen but overlaps when moved to my HD monitor and disappears when moved back.  Very consistent.
Can confirm what Jeremypw..@gmail.com said on 10 sep.
However if i connect my laptop with a HD monitor my laptop-default-sreen-zoom is set to 150%. The zoom of the HD screen is defaulted to 100% : 
When I increase the zoom on the HDmonitor the avatar-minimize issue disappears. 
See screenshot snips provided. 

I use W10, and chrome 53.0.2785.116m on a lenovo ideapad500S. 

100%_1280x800_HDmonitor.JPG
41.5 KB View Download
100%_1920x1080_laptop.JPG
79.8 KB View Download
150%_1680x1050_HDmonitor.JPG
78.5 KB View Download
150%_1920x1080_laptop.JPG
75.7 KB View Download
If you still see problems here, please file a new bug.  Even if they look similar to this bug, they may have a slightly different root cause and thus require a different fix.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-53; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-53 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
CL {#394806} listed at #17 is landed on May 19th. And M53 was branched on June, 30th Branched Chromium at revision 403382. So this change is already in M53, removing Merge-TBD label.

Comment 28 by trven...@gmail.com, Oct 18 2016

Facing the same issue and its annoying...
ASUS Laptop model G501J
Wacom Cintiq 22HD model DTK-2200/K
Windows 8.1
Chrome 54.0.2840.71 m

Dual display setup:
Primary = Wacom Cintiq 22HD, at 1920x1080.
Secondary = ASUS Laptop display, at 1920x1080.

On my primary display, the minimize button is mostly covered by the username. On my secondary display, the username button does not cover the minimize button. 

Chrome zoom is 100% on both displays. 

Windows settings for "Change the size of all items" are at their defaults (screenshot attached).

Dragging the Chrome window from one monitor to the other retains the button positions, until the window is resized or maximized.

If the Control Panel setting "Let me choose one scaling level for all my displays" is enabled, and I sign out/sign in, then the error does not occur.

However if I disable the checkbox, and I sign out/sign in, then the error re occurs but with a different offset. On the primary display, the username button is now positioned further to the left, away from the minimize button. On the secondary display, the username button is in the same position as before, next to the minimize button but not covering it.

Re-enabling the checkbox, and signing out/signing in, removes the offset.
2016-10-26_Control Panel_All Control Panel Items_Display_Screen Resolution.jpg
386 KB View Download
Definitely "Not Fixed!".
 -- Hewlett-Packard EliteBook 850
    -- Intel(R) HD Graphics 5500
    -- Display #1: laptop built-in 1920x1080
    -- Display #2: HP Compaq LA2405wg LCD monitor
    -- Display mode:  "Extend these displays"
       -- Display #2 is the "main display"
 -- Windows 8.1 Enterprise

bad_Chrome_login_icon_positioning.gif
119 KB View Download
I am experiencing this bug too using Chrome Version 55.0.2883.87 on Windows 8.1 Enterprise. It happens regardless of which user I've selected, size of the window, zoom, whether I'm using an external display, etc.
Chrome_Bug.png
2.2 KB View Download
definitely not fixed in version 55. 
bug-chrome.png
4.1 KB View Download
How do we get this bug reopened?
Agree, definitely not fixed. I don't know who closed it, seemed to be an admin, and I don't see how to reopen it. If anybody out there knows how to undo the close please do. It's a small problem but irritating and unnecessary.

- jeremypwatson@outlook.com

Comment 35 by grt@chromium.org, Jan 9 2017

Status: Assigned (was: Fixed)
kylixrd: would you take another look?
Thanks gtr!

kylixrd: Please Note - current reporters of this issue are running Windows 8+ on high dot-per-inch laptops or monitors (my screen is 2560x1440). Issue may be related to the scaling functions that Microsoft provides to properly display text and application graphics on high DPI screens. 
Rest assured, this is on my radar. I do have some tasks ahead of this one. I'll try and get to it soon.
Project Member

Comment 38 by sheriffbot@chromium.org, Feb 8 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Hi kylixrd. Can you please comment on when this bug will be fixed ?
It has been a long time since the issue has been reported. It is very annoying to see the name on top of minimize button.
Frankly, I don't think that after all this time anybody is interested in fixing this problem.  However, I have a solution for me tat will definitely work for you too, although a rather expensive one, I got a 4k monitor for my 4k laptop and, hey presto!  all fixed,
Chrome Version 56.0.2924.87 (64-bit)
Windows 10 (All updates)
Is on BOTH of my monitors, one is 1080p, other is 1440p.

This issue just came up for me yesterday, I had never seen it before.
Untitled.png
777 bytes View Download
@41: Looks like you're running at 1.5x.  Can you report what the scale factor is on each monitor and whether this reproduces consistently for you/whether it's affected by things like which monitor the window starts on/is dragged to?

@37: It looks like the more recent reports of this have to do with multiple monitors and non-1x scale factors.  This + the frame involvement means bsep@ may be a better owner.
1080p monitor is scale factor 0, 1440p is 1.5. Notice it is in active effect on both monitors. Dragging back and forth and resizing changes nothing.

Again, this issue only came up in the most recent update that I was pushed a few days ago.
Untitled.png
21.5 KB View Download
What is the easiest way to fix this problem of "first user" avatar on top of minimize/maximize buttons? I have read this thread but it's too technical for me.

Comment 45 by o...@axiswd.com, Apr 26 2017

I am also seeing this issue on Windows 8.1 laptop with an external monitor. I am attaching a screenshot with various settings I tried. Setting common scaling for all displays fixes the issue as a workaround, but still would be nice to get it fixed with the windows default so I don't have to be changing the settings.


scaling issue.png
360 KB View Download

Comment 46 by ew...@chromium.org, May 12 2017

Cc: ew...@chromium.org
Labels: -Pri-1 Pri-2
Status: Assigned (was: Available)
Re-marking as assigned. Moving to P2 given how long this bug as been open without a fix, and given that it sounds like there are workarounds.

kylixrd - is this still on your radar? Where does this bug rank on your list of priorities?
This was never fixed insofar as I know but I eventually made it go away permanently by buying a 4k monitor.  Works just fine now! Only cost a few hundred dollars.
I've submitted the following CL: https://codereview.chromium.org/2881563004/

I don't know for absolutely certain that this will fix the problem since I've not been able to reproduce it effectively. If there is any way someone who is able to reproduce it can apply this patch and try it out, that would be awesome. Meanwhile, I'll try and locate a system that can reproduce this.

Comment 49 by ew...@chromium.org, May 12 2017

Cc: est...@chromium.org pkasting@chromium.org
Adding some other folks working on the avatar chip at the moment.

Comment 51 by o...@axiswd.com, May 17 2017

Hey kylixrd,

I will be happy to try it out for you. Is there a way for me to download a compiled windows 8.1 compatible binary? I don't have a way to compile code from GIT on my laptop.

Thanks,

Otto
otto@,

These changes should be coming through the canary build channel within the next day, if not already. Just install the canary build from here: https://www.google.com/chrome/browser/canary.html. Thanks!

If these changes don't fully resolve the issues, a detailed description of any behavioral changes from before along with the precise steps used to reproduce it. Also, please include information about the resolution, and scaling of the monitors. Finally, did you log-out then log back in after changing the scaling?

Comment 53 by o...@axiswd.com, May 22 2017

Hi Kylixrd,

After installing the Canary Build I can report the issue was resolved. However the user needs to sign/out and then sign back in for the fix to take effect. I am attaching a screenshot with details of the testing that I did. 

Also interestingly, the changes in Canary seem to have taken effect on the regular Chrome build as well on my laptop. Not sure if this is because of some shared files or settings or simply because my Chrome updated itself to the latest version. 

Regardless I am also seeing the fix on my other laptop which uses regular Chrome with Windows 10, so this is good news!! :-)

Thanks!! Would be good if some of the other folks on the thread here can confirm the fix.
chrome issue.png
330 KB View Download
After installing Chrome Canary, the issue has also gone POOF for me as well. Thank goodness! That sure was annoying.

Comment 55 by ew...@chromium.org, May 23 2017

Should we mark this as Fixed?
Status: Fixed (was: Assigned)
I don't know how you call this fixed.  I still have the problem and on version 60 and over a year later.


Snap65.png
12.9 KB View Download
@57, can you file a new bug containing more information about how reproducible this is for you, as well as OS version, monitor setup, and scale factors?

Comment 59 by o...@axiswd.com, Aug 23 2017

@Kevin please post the link to your new bug here once you open it, it seems to be hapening on my laptop at home again as well. I will add further info to support your report.
This problem is still present in 
Version 60.0.3112.113 (Official Build) (64-bit)

It doesn't matter how big the chrome window is, the profile name always block the minimize button. Very annoying!
If you are still seeing this please do NOT post here, go file a new bug (see comment 58).

Sign in to add a comment