New issue
Advanced search Search tips

Issue 609355 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

gn check //media/cast fails

Project Member Reported by jrumm...@chromium.org, May 5 2016

Issue description

Running "gn check out/GN //media/cast/*" currently reports 127 violations. As part of  issue 599578  we're trying to fix these errors so that //media is clean. Opening this bug to track cleaning up the media/cast directory.

First couple of errors:
ERROR at //media/cast/cast_config.h:18:11: Include not allowed.
ERROR at //media/cast/cast_sender_impl.cc:7:11: Can't include this header from here.
ERROR at //media/cast/cast_sender_impl.h:9:11: Can't include this header from here.
ERROR at //media/cast/cast_receiver.h:13:11: Can't include this header from here.
ERROR at //media/cast/cast_sender.h:15:11: Can't include this header from here.
ERROR at //media/cast/common/transport_encryption_handler.cc:12:11: Include not allowed.

Typical error indicates what is missing:
ERROR at //media/cast/cast_config.h:18:11: Include not allowed.
#include "media/cast/net/cast_transport_config.h"
          ^-------------------------------------
It is not in any dependency of
  //media/cast:common
The include file is in the target(s):
  //media/cast:net
which should somehow be reachable.

Most of these are probably resolved by setting deps variable appropriately in the BUILD.gn file.
 

Comment 1 by mfo...@chromium.org, Oct 27 2016

Labels: -Pri-2 Pri-3

Comment 2 by mfo...@chromium.org, Oct 27 2016

Components: -Internals>Cast Internals>Cast>Streaming

Comment 3 by mfo...@chromium.org, Oct 27 2016

Status: Available (was: Untriaged)

Comment 4 by w...@chromium.org, Oct 29 2016

Owner: w...@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b0056868439b31aa72e10f82aae85b9d2b4ca2e

commit 1b0056868439b31aa72e10f82aae85b9d2b4ca2e
Author: wez <wez@chromium.org>
Date: Wed Nov 09 21:56:27 2016

Fix direct dependencies in //media/cast/BUILD.gn.

- Add direct dependencies (e.g. on //base) where missing.
- Move Codec and RtpPayloadType from
  //media/cast/net/cast_transport_config.h to //media/cast/cast_config.h
- Remove an unused header include.

Note that dependencies on //media/* sub-components, in the build targets for executables use //media to reach the sub-components, to avoid duplicate symbols in component builds, due to use of source_set for //media/* subcomponents.

BUG= 609355 ,  530839 

Review-Url: https://codereview.chromium.org/2462863002
Cr-Commit-Position: refs/heads/master@{#431043}

[modify] https://crrev.com/1b0056868439b31aa72e10f82aae85b9d2b4ca2e/media/cast/BUILD.gn
[modify] https://crrev.com/1b0056868439b31aa72e10f82aae85b9d2b4ca2e/media/cast/cast_config.h
[modify] https://crrev.com/1b0056868439b31aa72e10f82aae85b9d2b4ca2e/media/cast/common/transport_encryption_handler.cc
[modify] https://crrev.com/1b0056868439b31aa72e10f82aae85b9d2b4ca2e/media/cast/net/cast_transport_config.h

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e25ca8400bf8611c5f7733e6621c6dd9987ed922

commit e25ca8400bf8611c5f7733e6621c6dd9987ed922
Author: wez <wez@chromium.org>
Date: Fri Nov 11 02:05:12 2016

Enable 'gn check' for //media/cast

BUG= 609355 

Review-Url: https://codereview.chromium.org/2493643002
Cr-Commit-Position: refs/heads/master@{#431460}

[modify] https://crrev.com/e25ca8400bf8611c5f7733e6621c6dd9987ed922/.gn

Comment 7 by w...@chromium.org, Nov 11 2016

Status: Fixed (was: Started)

Sign in to add a comment