New issue
Advanced search Search tips

Issue 609351 link

Starred by 1 user
Status: Fixed
Owner:
btolsch@chromium.org
Closed: May 2016
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router WebUI] Search input and issue banner overlap.

Project Member Reported by apaci...@chromium.org, May 5 2016 
Started seeing this today; can repro on tip.

There's some extra whitespace between the last sink and both search/issue. It looks like both elements are vying for the most bottom real estate of the dialog.

It should look like:
<header>
<sink list>
<search>
<issue>
Screenshot from 2016-05-04 17:18:17.png
5.9 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8983fb03e941fb937b8ede5c18ac7e54d5564d2

commit d8983fb03e941fb937b8ede5c18ac7e54d5564d2
Author: btolsch <btolsch@chromium.org>
Date: Thu May 05 19:43:10 2016

[Media Router WebUI] Fix search input and issue overlap.

This change prevents the search input from overlapping non-blocking issues by
positioning the search input relative to its direct parent.

BUG= 609351 
R=apacible@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1953673002
Cr-Commit-Position: refs/heads/master@{#391875}

[modify] https://crrev.com/d8983fb03e941fb937b8ede5c18ac7e54d5564d2/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/d8983fb03e941fb937b8ede5c18ac7e54d5564d2/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Comment 2 by apaci...@chromium.org, May 6 2016

Components: Blink>PresentationAPI
Fixed for search input/non-blocking issue, but the search input now overlaps with sink names when there's a scroll bar.

Version 52.0.2726.0 canary (64-bit)
Screen Shot 2016-05-06 at 11.26.26.png
43.8 KB View Download

Comment 3 by mfo...@chromium.org, May 12 2016

Labels: Hotlist-Polish

Comment 4 by mfo...@chromium.org, May 12 2016

Cc: mfo...@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b367130a6de458010536cbf4722d36bb61cd1e26

commit b367130a6de458010536cbf4722d36bb61cd1e26
Author: btolsch <btolsch@chromium.org>
Date: Tue May 17 18:54:30 2016

[Media Router WebUI] Fix search input positioning when list scrolls.

This change prevents the search input from overlapping the sink list when the
sink list is larger than the dialog max height and has to scroll.

BUG= 609351 
R=apacible@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1962643005
Cr-Commit-Position: refs/heads/master@{#394177}

[modify] https://crrev.com/b367130a6de458010536cbf4722d36bb61cd1e26/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/b367130a6de458010536cbf4722d36bb61cd1e26/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/b367130a6de458010536cbf4722d36bb61cd1e26/chrome/test/data/webui/media_router/media_router_container_search_tests.js

Comment 6 by btolsch@chromium.org, May 17 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment