New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609346 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

BookmarkBubbleControllerTest.TestBubbleWindow fails under Material Design

Project Member Reported by shrike@chromium.org, May 5 2016

Issue description

Location bar metrics have changed under Material Design, causing a failure in the check for the test browser window fully containing the bookmarks bubble window.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4defec915ce29dba1f503057ba798a4ce2c7a27d

commit 4defec915ce29dba1f503057ba798a4ce2c7a27d
Author: shrike <shrike@chromium.org>
Date: Thu May 05 20:16:29 2016

[Mac][Material Design] Fix BookmarkBubbleControllerTest.TestBubbleWindow

This change adjusts the test for containment of the bubble window in the
test browser window. Metrics have changed under Material Design, so the
bokomarks window no longer fits completely within the test browser
window.

R=avi@chromium.org
BUG= 609346 

Review-Url: https://codereview.chromium.org/1952893002
Cr-Commit-Position: refs/heads/master@{#391889}

[modify] https://crrev.com/4defec915ce29dba1f503057ba798a4ce2c7a27d/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm
[modify] https://crrev.com/4defec915ce29dba1f503057ba798a4ce2c7a27d/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

Status: Fixed (was: Started)

Sign in to add a comment