Issue 609333 link

Starred by 2 users

Issue metadata

Status:	Verified
Owner:	█ apaci...@chromium.org no longer active
Closed:	May 2016
Cc:	mfo...@chromium.org btolsch@chromium.org powerb@chromium.org
Components:	Blink>PresentationAPI UI>Accessibility
EstimatedDays:	----
NextAction:	----
OS:	Windows , Chrome , Mac
Pri:	2
Type:	Bug
merge-merged-2704
Team-Accessibility

Cast mode drop down button doesn't have a label for screen readers

Project Member Reported by dbbrooks@chromium.org, May 4 2016

Issue description

Version: 51.0.
<b>OS: <please tell me it's not XP></b>

What steps will reproduce the problem?
(1) ctrl + alt + z enables ChromeVox screen reader on CrOS
(2) tab through MR dialog until you hit the drop down arrow for changing the cast mode

What is the expected output? 
Screen reader should say something like "Cast mode picker drop down"

What do you see instead?
Screen reader only says "drop down menu"


Please use labels and text to provide additional information.

Comment 1 by apaci...@chromium.org, May 4 2016

Labels: -Pri-3 Merge-Request-51 Pri-2

Requesting merge for https://codereview.chromium.org/1873013002/ to M51.

Comment 2 by dbbrooks@chromium.org, May 4 2016

Forgot to add the version info for this issue:
Chrome: 51.0.2704.15
MR: 5116.418.1.5

Comment 3 by bhthompson@chromium.org, May 5 2016

Labels: -Merge-Request-51 Merge-Approved-51

This seems to have been on ToT for some time now, so assuming it was tested there LGTM for R51.

Project Member

Comment 4 by bugdroid1@chromium.org, May 6 2016

Labels: -merge-approved-51 merge-merged-2704

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9281cb64b75191a123378b0b17bd9dc2e1c4ebb6

commit 9281cb64b75191a123378b0b17bd9dc2e1c4ebb6
Author: Jennifer Apacible <apacible@google.com>
Date: Thu May 05 23:55:38 2016

[Media Router WebUI] Update arrow drop title text to be more descriptive.

Initially landed at https://codereview.chromium.org/1873013002

BUG= 609333 

Review URL: https://codereview.chromium.org/1951863005 .

Cr-Commit-Position: refs/branch-heads/2704@{#404}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/9281cb64b75191a123378b0b17bd9dc2e1c4ebb6/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/9281cb64b75191a123378b0b17bd9dc2e1c4ebb6/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html
[modify] https://crrev.com/9281cb64b75191a123378b0b17bd9dc2e1c4ebb6/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
[modify] https://crrev.com/9281cb64b75191a123378b0b17bd9dc2e1c4ebb6/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc

Comment 5 by apaci...@chromium.org, May 6 2016

Status: Fixed (was: Assigned)

Project Member

Comment 6 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f018d5a7691f187c1e38977d472a729d7f57d31

commit 7f018d5a7691f187c1e38977d472a729d7f57d31
Author: Jennifer Apacible <apacible@google.com>
Date: Fri May 06 06:01:51 2016

Revert "[Media Router WebUI] Update arrow drop title text to be more descriptive."

This reverts commit 9281cb64b75191a123378b0b17bd9dc2e1c4ebb6.

Reason for revert is: bad merge.

TBR=imcheng@chromium.org
BUG= 609333 

Review URL: https://codereview.chromium.org/1955703003 .

Cr-Commit-Position: refs/branch-heads/2704@{#411}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/7f018d5a7691f187c1e38977d472a729d7f57d31/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/7f018d5a7691f187c1e38977d472a729d7f57d31/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html
[modify] https://crrev.com/7f018d5a7691f187c1e38977d472a729d7f57d31/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
[modify] https://crrev.com/7f018d5a7691f187c1e38977d472a729d7f57d31/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc

Project Member

Comment 7 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65c77408abc2da41de8daea1cf1e9b1b3e5f952f

commit 65c77408abc2da41de8daea1cf1e9b1b3e5f952f
Author: Jennifer Apacible <apacible@google.com>
Date: Fri May 06 07:07:19 2016

[Media Router WebUI] Update arrow drop title text to be more descriptive.

Initially landed at https://codereview.chromium.org/1873013002

BUG= 609333 

Review URL: https://codereview.chromium.org/1961443002 .

Cr-Commit-Position: refs/branch-heads/2704@{#412}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/65c77408abc2da41de8daea1cf1e9b1b3e5f952f/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/65c77408abc2da41de8daea1cf1e9b1b3e5f952f/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html
[modify] https://crrev.com/65c77408abc2da41de8daea1cf1e9b1b3e5f952f/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
[modify] https://crrev.com/65c77408abc2da41de8daea1cf1e9b1b3e5f952f/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc

Comment 8 by pbath...@chromium.org, May 17 2016

apacible@ -- could you let me know whats a MR dialog and few clear steps to verify this defect

Comment 9 by kathrelk...@chromium.org, May 26 2016

Status: Verified (was: Fixed)

lacking any response to #8 or further complaint about this bug, calling it as verified.

►

Issue 609333 link

Issue metadata

Cast mode drop down button doesn't have a label for screen readers

Issue description

Comment 1 by apaci...@chromium.org, May 4 2016

Comment 1 Deleted

Comment 2 by dbbrooks@chromium.org, May 4 2016

Comment 2 Deleted

Comment 3 by bhthompson@chromium.org, May 5 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, May 6 2016

Comment 4 Deleted

Comment 5 by apaci...@chromium.org, May 6 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, May 6 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, May 6 2016

Comment 7 Deleted

Comment 8 by pbath...@chromium.org, May 17 2016

Comment 8 Deleted

Comment 9 by kathrelk...@chromium.org, May 26 2016

Comment 9 Deleted

Sign in to add a comment