Issue 609318 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ dschuyler@chromium.org Last visit > 30 days ago
Closed:	Jul 2016
Cc:	dbeam@chromium.org tbuck...@chromium.org dpa...@chromium.org
Components:	UI>Settings
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
Proj-MaterialDesign-WebUI Hotlist-MD-Settings-Navigation

Ripple feedback needed on sidenav

Project Member Reported by bettes@chromium.org, May 4 2016

Issue description

There should be blue click feedback on all items in the sidenav. The ripple should explode from the point of contact. 

color: google blue 500, 0.5

Use Material chrome://history (requires flag flipped) as a proof of concept. The color of the ripple is incorrect, but implementation is correct

Comment 1 by dschuyler@chromium.org, May 5 2016

Status: Started (was: Assigned)

Comment 2 by dschuyler@chromium.org, May 7 2016

I have a working version of this locally, but it uses a fix to
Polymer that is still a pending pull request.

Comment 3 by tbuck...@chromium.org, May 24 2016

Labels: Hotlist-MD-Settings-Navigation

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/400f4cc71abe32ce79901c42cf685ed1aa816552

commit 400f4cc71abe32ce79901c42cf685ed1aa816552
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Jun 23 21:22:31 2016

[Polymer] update polymer

See components_summary.txt for versioning details.

NOPRESUBMIT=true  # crisper.js
BUG= 609318 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2089563002
Cr-Commit-Position: refs/heads/master@{#401718}

[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/bower.json
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/iron-fit-behavior/bower.json
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/iron-fit-behavior/iron-fit-behavior-extracted.js
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/iron-list/bower.json
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/iron-list/iron-list.html
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/iron-pages/bower.json
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-icon-button/bower.json
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button-light.html
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button.html
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-input/bower.json
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter.html
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-input/paper-input.html
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea.html
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-ripple/bower.json
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple.html
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-toolbar/bower.json
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components-chromium/paper-toolbar/paper-toolbar.html
[modify] https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812

commit 667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812
Author: dgozman <dgozman@chromium.org>
Date: Thu Jun 23 22:50:48 2016

Revert of [Polymer] update polymer (patchset #2 id:20001 of https://codereview.chromium.org/2089563002/ )

Reason for revert:
Breaks FileManagerBrowserTest: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/21683

Original issue's description:
> [Polymer] update polymer
>
> See components_summary.txt for versioning details.
>
> NOPRESUBMIT=true  # crisper.js
> BUG= 609318 
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/400f4cc71abe32ce79901c42cf685ed1aa816552
> Cr-Commit-Position: refs/heads/master@{#401718}

TBR=dbeam@chromium.org,dschuyler@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 609318 

Review-Url: https://codereview.chromium.org/2096903002
Cr-Commit-Position: refs/heads/master@{#401747}

[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/bower.json
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/iron-fit-behavior/bower.json
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/iron-fit-behavior/iron-fit-behavior-extracted.js
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/iron-list/bower.json
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/iron-list/iron-list.html
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/iron-pages/bower.json
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-icon-button/bower.json
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button-light.html
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button.html
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-input/bower.json
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter.html
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-input/paper-input.html
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea.html
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-ripple/bower.json
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple.html
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-toolbar/bower.json
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components-chromium/paper-toolbar/paper-toolbar.html
[modify] https://crrev.com/667fc8cfc1573b1eeb3cfa53b139b8eca7dfe812/third_party/polymer/v1_0/components_summary.txt

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9

commit 301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9
Author: dschuyler <dschuyler@chromium.org>
Date: Tue Jun 28 03:45:00 2016

[MD settings] update polymer

See components_summary.txt for versioning details.

NOPRESUBMIT=true  # crisper.js
BUG= 609318 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2092213003
Cr-Commit-Position: refs/heads/master@{#402396}

[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/bower.json
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/iron-fit-behavior/bower.json
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/iron-fit-behavior/iron-fit-behavior-extracted.js
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/iron-list/bower.json
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/iron-list/iron-list.html
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/iron-pages/bower.json
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-icon-button/bower.json
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button-light.html
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button.html
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-input/bower.json
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter-extracted.js
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter.html
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-input/paper-input.html
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea.html
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-ripple/bower.json
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple.html
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-toolbar/bower.json
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components-chromium/paper-toolbar/paper-toolbar.html
[modify] https://crrev.com/301c5cddbb3dfea3d626f89dcf9aa8aa3d78daa9/third_party/polymer/v1_0/components_summary.txt

Comment 7 by dschuyler@chromium.org, Jul 6 2016

This should be fixed when this lands:
https://codereview.chromium.org/2105833003/

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f49d51950d728ecbdcbfc0d269ce0879e9732c0

commit 7f49d51950d728ecbdcbfc0d269ce0879e9732c0
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Jul 07 18:41:36 2016

[MD settings] side nav ink ripple on click

This CL adds ripples to the side nav menu.

BUG= 609318 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2105833003
Cr-Commit-Position: refs/heads/master@{#404189}

[modify] https://crrev.com/7f49d51950d728ecbdcbfc0d269ce0879e9732c0/chrome/browser/resources/settings/settings_menu/compiled_resources2.gyp
[modify] https://crrev.com/7f49d51950d728ecbdcbfc0d269ce0879e9732c0/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/7f49d51950d728ecbdcbfc0d269ce0879e9732c0/chrome/browser/resources/settings/settings_menu/settings_menu.js

Comment 9 by dschuyler@chromium.org, Jul 7 2016

Status: Fixed (was: Started)

►

Issue 609318 link

Issue metadata

Ripple feedback needed on sidenav

Issue description

Comment 1 by dschuyler@chromium.org, May 5 2016

Comment 1 Deleted

Comment 2 by dschuyler@chromium.org, May 7 2016

Comment 2 Deleted

Comment 3 by tbuck...@chromium.org, May 24 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Jun 23 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jun 23 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Jun 28 2016

Comment 6 Deleted

Comment 7 by dschuyler@chromium.org, Jul 6 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Jul 7 2016

Comment 8 Deleted

Comment 9 by dschuyler@chromium.org, Jul 7 2016

Comment 9 Deleted

Sign in to add a comment